Fix vue 2.x selection logic #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
force-pushed
the
fix/vue2-7-detection
branch
from
1e0f7b4 to
c9780ee
Compare
IanVS
force-pushed
the
fix/vue2-7-detection
branch
from
c9780ee to
ee158fd
Compare
joshwooding
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #506
This corrects the vue 2.6 / 2.7 logic, and also finds a slightly-better way to handle module resolution from within
builder-vitewhen running examples. Instead of adding dev dependencies into the builder, this sets anode_pathenvironment variable, so that the node_modules of the example is used as a global lookup from within the builder.