Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing npm audit #84

Closed
wants to merge 1 commit into from
Closed

Fixing npm audit #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"dependencies": {
"@babel/standalone": "^7.4.5",
"he": "^1.2.0",
"marked": "^0.3.12"
"marked": "^0.7.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked already has 0.8.0 in 3 months ago
https://www.npmjs.com/package/marked

},
"devDependencies": {
"@babel/cli": "^7.0.0",
Expand Down
50 changes: 21 additions & 29 deletions src/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,9 @@ exports[`should be able to compile list 1`] = `

exports[`should be able to compile list with html tag 1`] = `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, @stof If we remove this testcase, and upgrade, then release as a new major version, I'm ok with that.

<div>
<font
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, unfortunately 😢

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fair. I'll check it out.

color="red"
>
this is root red text
</font>
<p>
&lt;font color="red"&gt; this is root red text &lt;/font&gt;
</p>
<ul>
<li>
list 1
Expand All @@ -216,21 +214,13 @@ exports[`should be able to compile list with html tag 1`] = `
list 2
</li>
<li>
<font
color="blue"
>
list blue text
</font>
&lt;font color="blue"&gt;list blue text&lt;/font&gt;
</li>
<li>
list 3
<ul>
<li>
<font
color="green"
>
two depth green text
</font>
&lt;font color="green"&gt;two depth green text&lt;/font&gt;
</li>
</ul>
</li>
Expand All @@ -240,24 +230,26 @@ exports[`should be able to compile list with html tag 1`] = `

exports[`should be able to compile multiple html 1`] = `
<div>
<p>
&lt;div&gt;hello&lt;/div&gt;
&lt;strong&gt;there&lt;/strong&gt;
&lt;em&gt;world&lt;/em&gt;
</p>
</div>
`;
<div>
<div>
hello
</div>


exports[`should be able to compile multiple html as components 1`] = `
<div>
<p>
&lt;div&gt;hello&lt;/div&gt;
&lt;strong&gt;there&lt;/strong&gt;
&lt;em&gt;world&lt;/em&gt;
</p>
<strong>
there
</strong>


<em>
world
</em>
</div>
</div>
`;

exports[`should be able to compile multiple html as components 1`] = `<div />`;

exports[`should be able to compile nested lists 1`] = `
<div>
<ul>
Expand Down