Skip to content

Commit

Permalink
Merge branch 'storybookjs:next' into fix/support-profiler-use-in-comp…
Browse files Browse the repository at this point in the history
…onent
  • Loading branch information
zhyd1997 authored Oct 21, 2022
2 parents c46aa2b + 3f77315 commit 117fab9
Show file tree
Hide file tree
Showing 810 changed files with 5,770 additions and 12,873 deletions.
80 changes: 50 additions & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

executors:
sb_node_14_classic:
sb_node_16_classic:
parameters:
class:
description: The Resource class
Expand All @@ -10,11 +10,11 @@ executors:
default: 'medium'
working_directory: /tmp/storybook
docker:
- image: cimg/node:14.19
- image: cimg/node:16.17.1
environment:
NODE_OPTIONS: --max_old_space_size=3076
resource_class: <<parameters.class>>
sb_node_14_browsers:
sb_node_16_browsers:
parameters:
class:
description: The Resource class
Expand All @@ -23,7 +23,7 @@ executors:
default: 'medium'
working_directory: /tmp/storybook
docker:
- image: cimg/node:14.19-browsers
- image: cimg/node:16.17.1-browsers
environment:
NODE_OPTIONS: --max_old_space_size=3076
resource_class: <<parameters.class>>
Expand Down Expand Up @@ -75,10 +75,26 @@ commands:
fi
jobs:
check:
executor:
class: xlarge
name: sb_node_16_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- restore_cache:
name: Restore Yarn cache
keys:
- build-yarn-2-cache-v4--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- run:
name: Check
command: |
yarn task --task check --start-from=auto --no-link --debug
git diff --exit-code
build:
executor:
class: xlarge
name: sb_node_14_classic
name: sb_node_16_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down Expand Up @@ -106,10 +122,11 @@ jobs:
- code/addons
- code/frameworks
- code/lib
- code/ui
- code/renderers
- code/presets
chromatic:
executor: sb_node_14_browsers
executor: sb_node_16_browsers
parallelism: 15
steps:
# Keep using default checkout because Chromatic needs some git history to work properly
Expand All @@ -124,8 +141,8 @@ jobs:
examples:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 6
name: sb_node_16_browsers
parallelism: 3
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -143,7 +160,7 @@ jobs:
publish:
executor:
class: medium
name: sb_node_14_classic
name: sb_node_16_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down Expand Up @@ -212,7 +229,7 @@ jobs:
name: Run @storybook/bench on repro
command: |
cd ../cra-bench
npx -p @storybook/bench@1.0.0--canary.12.7cccdee.0 sb-bench 'echo noop' --label cra
npx -p @storybook/bench@0.7.6--canary.760ff01.0 sb-bench 'echo noop' --label cra
- run:
name: prep artifacts
when: always
Expand All @@ -223,12 +240,12 @@ jobs:
smoke-tests:
executor:
class: medium+
name: sb_node_14_browsers
name: sb_node_16_browsers
environment:
# Disable ESLint when running smoke tests to improve perf + As of CRA 4.0.3, CRA kitchen sinks are throwing
# because of some ESLint warnings, related to: https://github.com/facebook/create-react-app/pull/10590
DISABLE_ESLINT_PLUGIN: 'true'
parallelism: 16
parallelism: 4
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -242,7 +259,7 @@ jobs:
lint:
executor:
class: medium
name: sb_node_14_classic
name: sb_node_16_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -254,7 +271,7 @@ jobs:
cd code
yarn lint
script-unit-tests:
executor: sb_node_14_browsers
executor: sb_node_16_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -268,7 +285,7 @@ jobs:
- store_test_results:
path: scripts/junit.xml
unit-tests:
executor: sb_node_14_browsers
executor: sb_node_16_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -288,7 +305,7 @@ jobs:
coverage:
executor:
class: small
name: sb_node_14_browsers
name: sb_node_16_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -304,8 +321,8 @@ jobs:
create-sandboxes:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 16
name: sb_node_16_browsers
parallelism: 22
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -323,8 +340,8 @@ jobs:
smoke-test-sandboxes:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 15
name: sb_node_16_browsers
parallelism: 22
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -338,8 +355,8 @@ jobs:
build-sandboxes:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 16
name: sb_node_16_browsers
parallelism: 22
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -357,8 +374,8 @@ jobs:
test-runner-sandboxes:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 16
name: sb_playwright
parallelism: 20
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -372,8 +389,8 @@ jobs:
chromatic-sandboxes:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 16
name: sb_node_16_browsers
parallelism: 22
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -388,7 +405,7 @@ jobs:
executor:
class: medium+
name: sb_playwright
parallelism: 16
parallelism: 22
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -410,6 +427,9 @@ workflows:
- lint:
requires:
- build
- check:
requires:
- build
- examples:
requires:
- build
Expand Down Expand Up @@ -439,9 +459,9 @@ workflows:
- create-sandboxes:
requires:
- publish
- smoke-test-sandboxes:
requires:
- create-sandboxes
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
requires:
- create-sandboxes
Expand Down
18 changes: 0 additions & 18 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

40 changes: 40 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Bug report 🐞
description: >-
Something is broken and you have a reliable reproduction? Let us know here.
For questions, please use "Question" below.
title: '[Bug]: '
labels:
- needs triage
- bug
body:
- type: textarea
id: description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is
validations:
required: true
- type: textarea
id: reproduce
attributes:
label: To Reproduce
description: >-
Please create a reproduction by running `npx sb@next repro` and
following the instructions. Read our
[documentation](https://storybook.js.org/docs/react/contribute/how-to-reproduce)
to learn more about creating reproductions.
placeholder: >-
Paste your repository and deployed reproduction here. We prioritize
issues with reproductions over those without.
render: shell
- type: textarea
id: system
attributes:
label: System
description: Please paste the results of `npx sb@next info` here.
render: shell
- type: textarea
id: context
attributes:
label: Additional context
description: Add any other context about the problem here.
20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

40 changes: 40 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Feature request 💡
description: Suggest an idea for this project
title: '[Feature Request]:'
labels:
- needs triage
- feature request
body:
- type: textarea
id: problem
attributes:
label: Is your feature request related to a problem? Please describe
description: >-
A clear and concise description of the problem. E.g. I'm always
frustrated when [...]
- type: textarea
id: describe
attributes:
label: Describe the solution you'd like
description: What would you like to see added to Storybook to solve problem?
validations:
required: true
- type: textarea
id: alternatives
attributes:
label: Describe alternatives you've considered
description: Any alternative solutions or features you've considered.
- type: dropdown
id: help
attributes:
label: Are you able to assist to bring the feature to reality?
options:
- 'no'
- yes, I can
validations:
required: true
- type: textarea
id: context
attributes:
label: Additional context
description: Add any other context or screenshots about the feature request here.
25 changes: 0 additions & 25 deletions .github/autolabeler.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/cron-weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
check-links:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: gaurav-nelson/github-action-markdown-link-check@v1
# checks all markdown files from important folders including all subfolders
with:
Expand Down
Loading

0 comments on commit 117fab9

Please sign in to comment.