Skip to content

Commit

Permalink
add safety if builder doesn't expose a bail method (builder-vite back…
Browse files Browse the repository at this point in the history
…wards compat)
  • Loading branch information
ndelangen committed May 26, 2022
1 parent c80a78b commit 8654a5c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/core-server/src/build-static.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,11 @@ export async function buildStaticStandalone(options: CLIOptions & LoadOptions &

const [managerStats, previewStats] = await Promise.all([
manager.catch(async (err) => {
await previewBuilder.bail();
await previewBuilder?.bail();
throw err;
}),
preview.catch(async (err) => {
await managerBuilder.bail();
await managerBuilder?.bail();
throw err;
}),
...extractTasks,
Expand Down
4 changes: 2 additions & 2 deletions lib/core-server/src/dev-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export async function storybookDevServer(options: Options) {

const [previewResult, managerResult] = await Promise.all([
preview.catch(async (err) => {
await managerBuilder.bail();
await managerBuilder?.bail();
throw err;
}),
manager
Expand All @@ -171,7 +171,7 @@ export async function storybookDevServer(options: Options) {
// return result;
// })
.catch(async (err) => {
await previewBuilder.bail();
await previewBuilder?.bail();
throw err;
}),
]);
Expand Down

0 comments on commit 8654a5c

Please sign in to comment.