Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/remove deprecations for 6.0.0 #10216

Merged
merged 22 commits into from
Mar 31, 2020
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion addons/contexts/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const createAddonDecorator: CreateAddonDecorator = render => {
name: ID,
parameterName: PARAM,
skipIfNoParametersOrOptions: true,
allowDeprecatedUsage: false,
wrapper,
});
};
1 change: 0 additions & 1 deletion addons/cssresources/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export const withCssResources = makeDecorator({
name: 'withCssResources',
parameterName: PARAM_KEY,
skipIfNoParametersOrOptions: true,
allowDeprecatedUsage: false,

wrapper: (getStory, context, { options, parameters }) => {
const storyOptions = parameters || options;
Expand Down
3 changes: 1 addition & 2 deletions addons/events/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@
"react": "^16.8.3",
"react-lifecycles-compat": "^3.0.4",
"react-textarea-autosize": "^7.0.4",
"regenerator-runtime": "^0.13.3",
"util-deprecate": "^1.0.2"
"regenerator-runtime": "^0.13.3"
},
"devDependencies": {
"@types/webpack-env": "^1.15.1"
Expand Down
37 changes: 0 additions & 37 deletions addons/events/src/deprecated.js

This file was deleted.

9 changes: 0 additions & 9 deletions addons/events/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { ReactNode } from 'react';

import addons from '@storybook/addons';
import CoreEvents from '@storybook/core-events';
import deprecate from 'util-deprecate';

import { EVENTS } from './constants';

Expand Down Expand Up @@ -49,15 +48,7 @@ interface Options {
events: Event[];
}

const WithEvents = deprecate(({ children, ...options }: Options) => {
addEvents(options);
return children;
}, `<WithEvents> usage is deprecated, use .addDecorator(withEvents({emit, events})) instead`);

export default (options: Options) => {
if (options.children) {
return WithEvents(options);
}
return (storyFn: () => ReactNode) => {
addEvents(options);
return storyFn();
Expand Down
3 changes: 1 addition & 2 deletions addons/jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@
"react": "^16.8.3",
"react-sizeme": "^2.5.2",
"regenerator-runtime": "^0.13.3",
"upath": "^1.1.0",
"util-deprecate": "^1.0.2"
"upath": "^1.1.0"
},
"devDependencies": {
"@types/webpack-env": "^1.15.1"
Expand Down
11 changes: 1 addition & 10 deletions addons/jest/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import addons, { Parameters, StoryFn } from '@storybook/addons';
import deprecate from 'util-deprecate';
import addons, { Parameters } from '@storybook/addons';
import { normalize, sep } from 'upath';
import { ADD_TESTS } from './shared';

Expand Down Expand Up @@ -55,14 +54,6 @@ export const withTests = (userOptions: { results: any; filesExt?: string }) => {
const options = { ...defaultOptions, ...userOptions };

return (...args: any[]) => {
if (typeof args[0] === 'string') {
return deprecate((storyFn: StoryFn<any>, { kind }: Parameters) => {
emitAddTests({ kind, story: storyFn, testFiles: (args as any) as string[], options });

return storyFn();
}, 'Passing component filenames to the `@storybook/addon-jest` via `withTests` is deprecated. Instead, use the `jest` story parameter');
}

const [storyFn, { kind, parameters = {} }] = args;
let { jest: testFiles } = parameters;

Expand Down
1 change: 0 additions & 1 deletion addons/knobs/angular.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/knobs/html.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/knobs/marko.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/knobs/mithril.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/knobs/polymer.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/knobs/react.js

This file was deleted.

29 changes: 0 additions & 29 deletions addons/knobs/src/deprecated.js

This file was deleted.

1 change: 0 additions & 1 deletion addons/knobs/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export const withKnobs = makeDecorator({
name: 'withKnobs',
parameterName: 'knobs',
skipIfNoParametersOrOptions: false,
allowDeprecatedUsage: true,
wrapper: (getStory, context, { options, parameters }) => {
const storyOptions = parameters || options;
const allOptions = { ...defaultOptions, ...storyOptions };
Expand Down
1 change: 0 additions & 1 deletion addons/knobs/vue.js

This file was deleted.

3 changes: 0 additions & 3 deletions addons/options/README.md

This file was deleted.

Binary file removed addons/options/docs/screenshot.png
Binary file not shown.
55 changes: 0 additions & 55 deletions addons/options/package.json

This file was deleted.

1 change: 0 additions & 1 deletion addons/options/register.js

This file was deleted.

6 changes: 0 additions & 6 deletions addons/options/src/constants.ts

This file was deleted.

70 changes: 0 additions & 70 deletions addons/options/src/index.ts

This file was deleted.

2 changes: 0 additions & 2 deletions addons/options/src/public_api.ts

This file was deleted.

14 changes: 0 additions & 14 deletions addons/options/src/register.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/options/src/typings.d.ts

This file was deleted.

10 changes: 0 additions & 10 deletions addons/options/tsconfig.json

This file was deleted.

6 changes: 1 addition & 5 deletions addons/viewport/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@
"global": "^4.3.2",
"memoizerific": "^1.11.3",
"prop-types": "^15.7.2",
"regenerator-runtime": "^0.13.3",
"util-deprecate": "^1.0.2"
},
"devDependencies": {
"@types/util-deprecate": "^1.0.0"
"regenerator-runtime": "^0.13.3"
},
"peerDependencies": {
"react": "*",
Expand Down
6 changes: 0 additions & 6 deletions addons/viewport/src/legacy_preview/index.ts

This file was deleted.

5 changes: 0 additions & 5 deletions addons/viewport/src/models/Viewport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ export interface Viewport {
name: string;
styles: Styles;
type: 'desktop' | 'mobile' | 'tablet' | 'other';
/*
* @deprecated
* Deprecated option?
*/
default?: boolean;
}

export interface ViewportStyles {
Expand Down
5 changes: 0 additions & 5 deletions addons/viewport/src/models/ViewportAddonParameter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,4 @@ export interface ViewportAddonParameter {
disable?: boolean;
defaultViewport?: string;
viewports?: ViewportMap;
/*
* @deprecated
* The viewport parameter `onViewportChange` is no longer supported
*/
onViewportChange?: never;
}
7 changes: 1 addition & 6 deletions addons/viewport/src/preview.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
export {
configureViewport,
DEFAULT_VIEWPORT,
INITIAL_VIEWPORTS,
MINIMAL_VIEWPORTS,
} from './legacy_preview';
export { INITIAL_VIEWPORTS, DEFAULT_VIEWPORT, MINIMAL_VIEWPORTS } from './defaults';
Loading