Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocsPage: Remove slots for 6.0 #10259

Merged
merged 6 commits into from
Mar 31, 2020
Merged

DocsPage: Remove slots for 6.0 #10259

merged 6 commits into from
Mar 31, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 31, 2020 •
edited
Loading

Issue: #10224

What I did

  • Remove DocsPage slots
  • Added a few convenience props
  • Add migration docs

How to test

See attached stories

@shilman shilman requested a review from usulpro as a code owner March 31, 2020 04:26
@shilman shilman requested a review from tmeasday March 31, 2020 04:27
@shilman shilman modified the milestones: 6.0 breaking, 6.0 Mar 31, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2020 •
edited
Loading

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 56fa0ad

tmeasday
tmeasday approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@shilman shilman merged commit fda616e into next Mar 31, 2020
@shilman shilman deleted the 10224-remove-docspage-slots branch March 31, 2020 06:25
@shilman shilman mentioned this pull request Mar 31, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: docs BREAKING CHANGE
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday