Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: apply better dispatch #10989

Closed
wants to merge 4 commits into from
Closed

ci: apply better dispatch #10989

wants to merge 4 commits into from

Conversation

tooppaaa
Copy link
Contributor

Apply @gaetanmaisse logic on other scripts

@tooppaaa tooppaaa added the maintenance User-facing maintenance tasks label May 29, 2020
@tooppaaa tooppaaa requested a review from gaetanmaisse May 29, 2020 21:20
@tooppaaa tooppaaa self-assigned this May 29, 2020
@tooppaaa tooppaaa mentioned this pull request May 29, 2020
Merged
Base automatically changed from fix-10915-cli-init-in-yarn-workspace to next June 1, 2020 15:28
@ndelangen
Copy link
Member

I think a .ts file is used by a .js file now?

@tooppaaa
Copy link
Contributor Author

tooppaaa commented Jun 5, 2020

Yes but it's fine in that direction.

@ndelangen
Copy link
Member

No it's not?

something.js > something-elese.ts
can't work AFAIK

something.ts > something-elese.js
can, but that's not what's happening AFAIKS

@tooppaaa
Copy link
Contributor Author

tooppaaa commented Jun 8, 2020

Yep you're right ! We can wait #10785 to be merged for this one.

@ndelangen
Copy link
Member

@tooppaaa That PR seems to be not great for performance. The Ts migration of the scripts seems to add a lot of weight. @yannbf reported it was actually slower on his machine then before...

I'm unsure what to do about it...
So for now that PR is on pause, unless we can find some way of making that performant?

@shilman shilman self-assigned this Jul 10, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Aug 1, 2020
@shilman
Copy link
Member

shilman commented Aug 9, 2020

@tooppaaa what's going on with this one?

@stale stale bot removed the inactive label Aug 9, 2020
@tooppaaa
Copy link
Contributor Author

Unsure. Let's drop it :) changes are minimal

@tooppaaa tooppaaa closed this Aug 10, 2020
@stof stof deleted the tech/dispatchCI branch May 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@gaetanmaisse gaetanmaisse Awaiting requested review from gaetanmaisse

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@shilman shilman

@tooppaaa tooppaaa

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tooppaaa @ndelangen @shilman