Core: Fix webpack recursion in mainjs glob processing logic #11647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`../base-dir/*/index.stories.jsx` will lead to `glob` being set to `*/index.stories.jsx` and so `glob.split('/').length` = 2.
With the existing code the `recursive` flag would _not_ be set and yet webpack will need to recurse into the directories in order to find any `index.stories.jsx` files that might exist within them.
Therefore, we should compare to 1 and not 2.
See: #11530 (comment)
daniel-ac-martin
requested review from
alterx,
igor-dv and
tmeasday
as code owners
|
Unfortunately, the |
Adds some crude tests for when we expect to run webpack's `require.context` in recursive mode.
|
I had a think about this and I think it's possible to have some tests for this, even if they are quite crude test. So I've added that. |
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
../base-dir/*/index.stories.jsxwill lead toglobbeing set to*/index.stories.jsxand soglob.split('/').length= 2.With the existing code the
recursiveflag would not be set and yet webpack will need to recurse into the directories in order to find anyindex.stories.jsxfiles that might exist within them.Therefore, we should compare to 1 and not 2.
See: #11530 (comment)