Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix existing behavior with story prefixes #11660

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Core: Fix existing behavior with story prefixes #11660

merged 1 commit into from
Jul 23, 2020

Conversation

tmeasday
Copy link
Member

Issue: #11571

What I did

Made sure if the prefix isn't an exact match it does the previous behaviour (chooses the first matching story)

How to test

  • Is this testable with Jest or Chromatic screenshots? Test

@tmeasday tmeasday requested a review from shilman July 23, 2020 03:55
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 07c7e47

shilman
shilman approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@shilman shilman changed the title Fix existing behaviour with prefixes Core: Fix existing behavior with story prefixes Jul 23, 2020
@shilman shilman merged commit c70c68e into next Jul 23, 2020
@shilman shilman mentioned this pull request Jul 27, 2020
Closed
@stof stof deleted the 11571-fix-prefix-redirect-2 branch May 25, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman