Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mithril: Add Mithril v2.0.0 to peer dependencies #12229

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Mithril: Add Mithril v2.0.0 to peer dependencies #12229

merged 1 commit into from
Aug 25, 2020

Conversation

josephspurrier
Copy link
Contributor

@josephspurrier josephspurrier commented Aug 25, 2020

Issue: #11742

This will prevent the error when doing an npm install: npm WARN @storybook/[email protected] requires a peer of mithril@^1.1.6 but none is installed. You must install peer dependencies yourself.

What I did

Added support for v2 of Mithril

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

This will prevent the error when doing an npm install: `npm WARN @storybook/[email protected] requires a peer of mithril@^1.1.6 but none is installed. You must install peer dependencies yourself.` #11742
@shilman shilman changed the title Add v2.0.0 of Mithril for peer dependencies Mithril: Add Mithril v2.0.0 to peer dependencies Aug 25, 2020
@shilman shilman added this to the 6.0.x milestone Aug 25, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@shilman shilman merged commit d4c145d into storybookjs:next Aug 25, 2020
@josephspurrier josephspurrier deleted the patch-1 branch August 25, 2020 11:52
@josephspurrier
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants