Core: Fix --static-dir with absolute path on Windows
#13344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
requested review from
alterx,
igor-dv and
tmeasday
as code owners
ghengeveld
changed the title
--static-dir with absolute path on Windows
shilman
requested changes
Dec 1, 2020
Done |
The value is false, so could also argue it should just be removed.
Update storybook-preview-head-example.html.mdx
Addon-storyshots: Add React as peer dependency
A `useLegacyRendering` flag allows to use old rendering engine
Configure app/angular package as jest projects Allow to use jest-preset-angular for app/angular tests
ghengeveld
requested review from
aaronmcadam,
alexandrebodin,
CodeByAlex,
dangreenisrael,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
stijnkoopal,
theinterned,
thomasbertet,
usulpro and
z4o4z
as code owners
ghengeveld
requested review from
shilman
and removed request for
igor-dv,
z4o4z,
usulpro,
CodeByAlex and
thomasbertet
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13336
What I did
Primarily this fixes the handling of the
-s(--static-dir) flag for Windows users. This flag accepts a string in the shape of<dirname>:<endpoint>. Currently it fails to handle absolute paths on Windows: for a value likeC:\pathit would assumeCto be the dirname and\paththe endpoint. That bug is addressed here.Besides fixing the bug at hand, I've extracted this piece of logic into a util, because it previously existed in two separate places. The util is now under unit test and the surrounding code has been cleaned up with some nicer logging. I've also replaced
shelljswithcopyfromfs-extra. One less dependency 📉How to test
If your answer is yes to any of these, please make sure to include it in your PR.