Angular: Add Angular 11.1 support #13704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
shilman
added
the
run e2e extended test suite
gaetanmaisse
changed the title
shilman
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
LGTM. Thanks for jumping on top of this @gaetanmaisse! Smoke test failures are unrelated to this PR and @j3rem1e and I are investigating separately. Merging so we can test this & patch to master if it's working
This was referenced Jan 22, 2021
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13689, #13563 surely #13693
What I did
Some internal plumbing about webpack config changed in the latest version of Angular, for details see angular/angular-cli@eb30a92. As Storybook is using private function of
@angular-devkit/build-angularI added the new required properties in the webpack config.I also updated the Angular example and the Angular dependencies in the app to Angular 11.1.
How to test