Add missing peer dependencies #16551
Conversation
Nx Cloud ReportCI ran the following commands for commit 75569d3. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
| "peerDependencies": { | ||
| "react": "^16.8.0 || ^17.0.0", | ||
| "react-dom": "^16.8.0 || ^17.0.0" | ||
| }, |
There was a problem hiding this comment.
In principle this is fine, I fear it might introduce global React types for Vue projects.
There was a problem hiding this comment.
no should be fine, we have these in other packages that are not react-specific already.
| "peerDependencies": { | ||
| "react": "^16.8.0 || ^17.0.0", | ||
| "react-dom": "^16.8.0 || ^17.0.0" | ||
| }, |
There was a problem hiding this comment.
no should be fine, we have these in other packages that are not react-specific already.
|
@shilman LGTM, should i be concerned about these tests? |
|
@ndelangen no, i'm mostly worried about the examples not building |
Methuselah96
force-pushed
the
patch-1
branch
from
3144e4a to
75569d3
Compare
|
@ndelangen @shilman I did a rebase and it looks like the examples are building now. |
|
Thanks @Methuselah96 !!! 🙏 |
Issue: related to #14838
What I did
Fixed these implicit transitive peer dependency warnings:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.