Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs/Svelte: Fix HOC.svelte reference #17731

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Addon-docs/Svelte: Fix HOC.svelte reference #17731

merged 1 commit into from
Mar 16, 2022

Conversation

ndelangen
Copy link
Member

Issue:

What I did

I noticed the e2e test (extended-core) failing on next, this fixes that.

@shilman it seems you moved this file, but made a reference to in to the src directory, which we do not publish to npm, hence the CI failure in e2e

@nx-cloud
Copy link

nx-cloud bot commented Mar 16, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 8b7e6fe. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Mar 16, 2022
@ndelangen ndelangen requested a review from shilman March 16, 2022 13:15
@ndelangen ndelangen added the bug label Mar 16, 2022
@shilman shilman changed the title fix svelte HOC.svelte reference Addon-docs/Svelte: Fix HOC.svelte reference Mar 16, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. Thanks @ndelangen 🙏

@shilman shilman merged commit ca95b2b into next Mar 16, 2022
@shilman shilman deleted the fix/svelte-e2e branch March 16, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants