Core-webpack: Factor out webpack dependencies #18114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6e10a3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
added
configuration babel / webpack
maintenance
shilman
changed the title
3 tasks
Base automatically changed from
future/minimize-webpack-deps
to
future/add-frameworks
May 11, 2022 12:07
shilman
commented
May 11, 2022
lib/webpack-tools/README.md
Outdated
| @@ -0,0 +1,9 @@ | |||
| # Storybook Core-Common | |||
shilman
commented
May 11, 2022
| * Modify or return a custom Webpack config after the Storybook's default configuration | ||
| * has run (mostly used by addons). | ||
| */ | ||
| webpack?: (config: Configuration, options: Options) => Configuration | Promise<Configuration>; |
There was a problem hiding this comment.
FIXME: this should come from core-webpack
shilman
commented
May 11, 2022
lib/webpack-tools/src/types.ts
Outdated
|
|
||
| export type { Options, Preset, BuilderResult, TypescriptOptions } from '@storybook/core-common'; | ||
|
|
||
| export interface CommonWebpackConfiguration { |
There was a problem hiding this comment.
FIXME comment: this is the bare minimum type that our common code expects all versions of webpack to implement. in the future we can update this as needed, but we will also need to update the utility code.
shilman
changed the title
3 tasks
shilman
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Telescoping PR, builds on #18018
What I did
core-commoncore-webpackthat handles common webpack types & utilitiesHow to test