-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Story/Meta typings for Svelte #19031
Conversation
Hey, @anthonator. Thanks for this effort! And congratulations on your first contribution! 🥳 A couple things of note here:
Thanks again for taking the time to improve Svelte types! |
@anthonator could you please rebase on the |
@kasperpeulen perhaps this is relevant for your work on types? |
@ndelangen I'm afraid I don't know enough about Storybook to be able to review this PR. I'm happy to answer Svelte-specific questions though |
@JReinhold perhaps you could take a peek at this one? |
I think this looks like a pretty simple migration of React types to Svelte types so this is good! But I assume that @kasperpeulen's refactoring of the type system is going to have an effect on this, so I think his say is the most important. |
@ndelangen The Svelte types are already in the 7 release, and I'm improving those this week. So I guess the question is, do we want to backport those types to 6, otherwise, this PR is already done. |
Starting on better CSF3 types for svelte in: |
Issue: Svelte renderer doesn't have support for the
Story
andMeta
types like React and Vue do. This results inProperty 'args' does not exist on type
type errors when using TypeScript in stories.What I did
I added the missing typings.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.