Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable smoke test on cra/default-ts #19352

Merged
merged 5 commits into from
Oct 5, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable smoke test on cra/default-ts
tmeasday committed Oct 5, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 17ddcb71ba4654e5b1e3dc73e22b5212a5af582a
2 changes: 2 additions & 0 deletions code/lib/cli/src/repro-templates.ts
Original file line number Diff line number Diff line change
@@ -13,6 +13,8 @@ const craTemplates = {
name: 'Create React App (Typescript)',
script: 'npx create-react-app . --template typescript',
cadence: ['ci', 'daily', 'weekly'],
// Re-enable once https://github.com/storybookjs/storybook/issues/19351 is fixed.
skipTasks: ['smoke-test'],
expected: {
framework: '@storybook/cra',
renderer: '@storybook/react',
4 changes: 2 additions & 2 deletions scripts/get-template.ts
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ const sandboxDir = resolve(__dirname, '../sandbox');
export type Cadence = 'ci' | 'daily' | 'weekly';
export type Template = {
cadence?: readonly Cadence[];
skipScripts?: string[];
skipTasks?: string[];
// there are other fields but we don't use them here
};
export type TemplateKey = string;
@@ -42,7 +42,7 @@ export async function getTemplate(
const cadenceTemplates = allTemplates.filter(([, template]) =>
template.cadence.includes(cadence)
);
const jobTemplates = cadenceTemplates.filter(([, t]) => !t.skipScripts?.includes(scriptName));
const jobTemplates = cadenceTemplates.filter(([, t]) => !t.skipTasks?.includes(scriptName));
potentialTemplateKeys = jobTemplates.map(([k]) => k);
}