Core: Support recursive addon imports #19530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19176
What I did
This is an attempt to implement the idea in #19176 to pre-require the sub-addons of addon-essentials, so that the preview builders don't need to, thus avoiding problems with pnpm and yarn pnp.
However, after we do import those, we have the problem of getting them into the preview itself. That's a challenge, since these are functions, and as far as I know, can't be properly serialized. But, maybe there's a way to do it?
How to test
To see the issue, you can compile the code and create a vite sandbox. When it tries to start up, you'll get an error about path only importing strings, and that's because the builder still expects a list of package names.