Fix Vite builder source loader plugin #19610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
reviewed
Oct 24, 2022
joshwooding
force-pushed
the
fix-vite-builder-source-loader-plugin
branch
from
575a656 to
abdbe93
Compare
joshwooding
force-pushed
the
fix-vite-builder-source-loader-plugin
branch
from
abdbe93 to
685f8de
Compare
joshwooding
force-pushed
the
fix-vite-builder-source-loader-plugin
branch
from
685f8de to
73b9f2d
Compare
|
Will this still be required if we go with #19680? |
|
Hi Josh, I'm merging #19680 so I'm going to close this. Can you please integrate that instead? Happy to chat about it on Discord and/or pair if it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19554
What I did
Added getOptions to the mocked class loader.
sourceloader doesn't have any types so I added expect error.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.