Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Fix preview annotation paths on Windows #19822

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Nov 14, 2022

issue: #19824

Not sure if it's related to https://discord.com/channels/486522875931656193/1040648399973781535

But I ran into this when trying to run the vite sandbox

@joshwooding joshwooding requested a review from IanVS November 14, 2022 01:49
@IanVS IanVS changed the title Fix preview annotations with the Vite builder on Windows Vite: Fix preview annotation paths on Windows Nov 14, 2022
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the CI failures are unrelated.

@shilman shilman merged commit b0c013a into storybookjs:next Nov 14, 2022
@joshwooding joshwooding deleted the fix-preview-annotations-in-windows-vite-builder branch November 14, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants