Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder-vite: normalize absolute paths when processing preview annotations #19828

Closed
wants to merge 6 commits into from
Closed

Builder-vite: normalize absolute paths when processing preview annotations #19828

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0735707
Merge pull request #1 from storybookjs/next
Dschungelabenteuer Jul 22, 2022
3c98dba
Merge branch 'storybookjs:next' into next
Dschungelabenteuer Aug 24, 2022
a89b9fb
Merge branch 'storybookjs:next' into next
Dschungelabenteuer Aug 25, 2022
c1a800e
Merge branch 'storybookjs:next' into next
Dschungelabenteuer Nov 8, 2022
f76985e
Merge branch 'next' of https://github.com/Dschungelabenteuer/storyboo…
Dschungelabenteuer Nov 14, 2022
7a6cb69
Normalize absolute paths for preview annotations
Dschungelabenteuer Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/lib/builder-vite/src/utils/process-preview-annotation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { PreviewAnnotation } from '@storybook/types';
import { resolve } from 'path';
import { normalizePath } from 'vite';

/**
* Preview annotations can take several forms, and vite needs them to be
Expand Down Expand Up @@ -29,5 +30,5 @@ export function processPreviewAnnotation(path: PreviewAnnotation | undefined) {
throw new Error('Could not determine path for previewAnnotation');
}

return path;
return normalizePath(path);
}