Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: make tests use SWC, not babel #20350

Closed
wants to merge 4 commits into from

Conversation

ndelangen
Copy link
Member

Issue: #18732

Telescoped on: #20156

And now using SWC for transforming in jest

@ndelangen ndelangen changed the base branch from next to tech/remove-prepare-babel December 20, 2022 18:00
@ndelangen ndelangen requested review from IanVS and tmeasday December 20, 2022 18:00
@ndelangen ndelangen self-assigned this Dec 20, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Dec 20, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, seems cool. So do we need to go back to using global vars for it/expect etc?

@ndelangen
Copy link
Member Author

@tmeasday honestly, it's been a bit of an experimentation. Seeing how much babel stuff I could clean-up.

Good news is: It seems I can make all of it go away, pretty much!


Because of the long list of telescoped PRs (trying to make smaller PRs that can be reviewed) I easily get into merge conflicts, and then try to fix them any way I can.

I suppose we should chat about these PRs and if we want them in 7.0 at all. If we decide we DO, I should start running all sandboxes on them, and get them merged 1 by 1, slowly and carefully.

@IanVS
Copy link
Member

IanVS commented Dec 22, 2022

Any reason this needs to be telescoped onto the other PRs, and we shouldn't just commit it straight to next?

@ndelangen
Copy link
Member Author

ndelangen commented Dec 22, 2022

That sounds like a plan @IanVS!

It's probably not going to get the highest priority from me, since i only have a few more days until my trip.

This sounds like an easy contribution for someone to pick as their first contribution maybe?

General idea of the task:

  • make a new branch based on next
  • cherry pick the commits from the PR
  • resolve conflicts
  • make sure (unit) tests run & all pass
  • submit PR with description

@ifndefdeadmau5
Copy link

May I take this one if anyone wouldn't mind? : )

@ndelangen
Copy link
Member Author

closed in favor of #20397

@ndelangen ndelangen closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants