Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release tooling: Fix commit comparing #23047

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Release tooling: Fix commit comparing #23047

merged 1 commit into from
Jun 13, 2023

Conversation

kasperpeulen
Copy link
Contributor

What I did

Fix commit comparing in release tooling as we use full hashes everwhere now

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen requested a review from shilman June 13, 2023 13:19
@kasperpeulen kasperpeulen added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Jun 13, 2023
@kasperpeulen kasperpeulen merged commit 55b1627 into next Jun 13, 2023
@kasperpeulen kasperpeulen deleted the kasper/compare-commits branch June 13, 2023 13:20
kasperpeulen added a commit that referenced this pull request Jun 13, 2023
@kasperpeulen
Merge pull request #23047 from storybookjs/kasper/compare-commits
64cde8e 
Release tooling: Fix commit comparing
This was referenced Jun 13, 2023
Merged
Merged
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
@kasperpeulen kasperpeulen added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Jun 14, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @shilman