Docs: Update ColorPallete and example #28741
Conversation
- Updated documentation to include support for gradients in ColorItem. - Mentioned examples of valid gradient formats such as 'linear-gradient(to right, white, black)' and 'linear-gradient(65deg, white, black)'.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
jonniebigodes
changed the title
There was a problem hiding this comment.
@aberllin, thanks for putting together this pull request and helping us improve the documentation by adding this small but important example. We appreciate it 🙏 !
I left a small item for you to look into when you can.
Let me know once you've addressed it, and I'll take a look. If nothing more stands out, I'll gladly merge this pull request.
I hope you have a fantastic day.
Stay safe
| <ColorItem | ||
| title="gradient" | ||
| subtitle="Grayscale" | ||
| colors={{ | ||
| Gradient: 'linear-gradient(to right,white,black)', | ||
| }} | ||
| /> | ||
| <ColorItem | ||
| title="gradient" | ||
| subtitle="Grayscale" | ||
| colors={['linear-gradient(65deg,white,black)']} | ||
| /> |
There was a problem hiding this comment.
@aberllin when you have a moment, can you adjust the spacing to match the rest of the example, as it's a bit off? It's using 4 spaces when it should be 2 spaces instead.
There was a problem hiding this comment.
Hi @jonniebigodes , please check again!
Thank you
|
@aberllin thanks for addressing the feedback so promptly. Appreciate it 🙏 ! All is good on my end. Will merge once the checklist clears. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 65561ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jonniebigodes
added
documentation
patch:yes
Docs: Update ColorPallete and example (cherry picked from commit 61b8fc3)
Docs: Update ColorPallete and example (cherry picked from commit 61b8fc3)
Docs: Update ColorPallete and example (cherry picked from commit 61b8fc3)
Docs: Update ColorPallete and example (cherry picked from commit 61b8fc3)
github-actions
bot
added
the
patch:done
What I did
Related to the issue: #10232
Documentation
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>