Toolbars: Suppress deprecation warning when using dynamic icons #29545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25760
What I did
Removed deprecation warnings
![image](https://private-user-images.githubusercontent.com/10867286/383104648-474b1e41-4083-46bd-9980-8641063d598b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDIyMDMsIm5iZiI6MTczOTY0MTkwMywicGF0aCI6Ii8xMDg2NzI4Ni8zODMxMDQ2NDgtNDc0YjFlNDEtNDA4My00NmJkLTk5ODAtODY0MTA2M2Q1OThiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE3NTE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjNTZlMTI1ZWE0OWRhNWRlMDQ4NTUzOWI4NTIyMmRkYWYxOTI3MDhjMTVkZmUwNTljOWNjODQxNWMxYTMwZGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.L5HSPKJ542ClCAwnjJdzsXT0Zq3frtvX9Y1rH-ybyMM)
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn start
Theme
menuDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Adds
__suppressDeprecationWarning
prop to Icons component in the toolbar addon to temporarily silence console warnings about deprecated icon usage.code/addons/toolbars/src/components/ToolbarMenuListItem.tsx
to add__suppressDeprecationWarning={true}
to Icons component