Core: Add defineConfig helper for main.js #30250

yannbf · 2025-01-13T07:45:04Z

What I did

This PR introduces a defineConfig type helper for storybook main configs, a base config in core common and extended ones from each framework

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	after	diff	z	%
createSize	0 B	0 B	-	-
generateSize	77.9 MB	77.9 MB	-	100%
initSize	131 MB	131 MB	-	100%
diffSize	53.4 MB	53.4 MB	-	100%
buildSize	7.19 MB	7.19 MB	-	100%
buildSbAddonsSize	1.85 MB	1.85 MB	-	100%
buildSbCommonSize	195 kB	195 kB	-	100%
buildSbManagerSize	1.87 MB	1.87 MB	-	100%
buildSbPreviewSize	0 B	0 B	-	-
buildStaticSize	0 B	0 B	-	-
buildPrebuildSize	3.91 MB	3.91 MB	-	100%
buildPreviewSize	3.28 MB	3.28 MB	-	100%
testBuildSize	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	0ms	8.2s	8.2s	-	100%
generateTime	0ms	25.9s	25.9s	-	100%
initTime	0ms	21.3s	21.3s	-	100%
buildTime	0ms	8.6s	8.6s	-	100%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	0ms	5s	5s	-	100%
devManagerResponsive	0ms	3.8s	3.8s	-	100%
devManagerHeaderVisible	0ms	574ms	574ms	-	100%
devManagerIndexVisible	0ms	604ms	604ms	-	100%
devStoryVisibleUncached	0ms	1.9s	1.9s	-	100%
devStoryVisible	0ms	610ms	610ms	-	100%
devAutodocsVisible	0ms	634ms	634ms	-	100%
devMDXVisible	0ms	509ms	509ms	-	100%
buildManagerHeaderVisible	0ms	749ms	749ms	-	100%
buildManagerIndexVisible	0ms	751ms	751ms	-	100%
buildStoryVisible	0ms	733ms	733ms	-	100%
buildAutodocsVisible	0ms	530ms	530ms	-	100%
buildMDXVisible	0ms	551ms	551ms	-	100%

Greptile Summary

Adds a new defineConfig helper function to enhance type inference for Storybook configurations across all frameworks.

Added code/core/src/common/defineConfig.ts with type-safe configuration helper
Added export of defineConfig in code/core/src/common/index.ts
Added framework-specific defineConfig wrappers in all framework types.ts files
Maintains consistent type safety across React, Vue, Svelte, Angular and other framework implementations
Improves TypeScript support for main.ts configuration files without breaking changes

nx-cloud · 2025-01-13T07:46:52Z

View your CI Pipeline Execution ↗ for commit 9df03e6.

Command	Status	Duration	Result
`nx run-many -t build --parallel=3`	✅ Succeeded	1m 43s	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-17 12:45:40 UTC

greptile-apps

_{21 file(s) reviewed, 13 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

code/frameworks/angular/src/types.ts

code/frameworks/ember/src/types.ts

code/frameworks/html-vite/src/types.ts

code/frameworks/react-webpack5/src/types.ts

code/frameworks/preact-vite/src/types.ts

code/frameworks/react-vite/src/types.ts

code/frameworks/web-components-webpack5/src/types.ts

storybook-pr-benchmarking · 2025-01-17T11:47:07Z

Package Benchmarks

^{Commit: 9df03e6, ran on 17 January 2025 at 12:50:01 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-a11y`

	Before	After	Difference
Dependency count	0	59	🚨 +59 🚨
Self size	0 B	228 KB	🚨 +228 KB 🚨
Dependency size	0 B	13.46 MB	🚨 +13.46 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-actions`

	Before	After	Difference
Dependency count	0	7	🚨 +7 🚨
Self size	0 B	59 KB	🚨 +59 KB 🚨
Dependency size	0 B	3.22 MB	🚨 +3.22 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-backgrounds`

	Before	After	Difference
Dependency count	0	4	🚨 +4 🚨
Self size	0 B	27 KB	🚨 +27 KB 🚨
Dependency size	0 B	99 KB	🚨 +99 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-controls`

	Before	After	Difference
Dependency count	0	3	🚨 +3 🚨
Self size	0 B	260 KB	🚨 +260 KB 🚨
Dependency size	0 B	47 KB	🚨 +47 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-docs`

	Before	After	Difference
Dependency count	0	17	🚨 +17 🚨
Self size	0 B	2.20 MB	🚨 +2.20 MB 🚨
Dependency size	0 B	7.88 MB	🚨 +7.88 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-essentials`

	Before	After	Difference
Dependency count	0	36	🚨 +36 🚨
Self size	0 B	15 KB	🚨 +15 KB 🚨
Dependency size	0 B	13.83 MB	🚨 +13.83 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-mdx-gfm`

	Before	After	Difference
Dependency count	0	69	🚨 +69 🚨
Self size	0 B	3 KB	🚨 +3 KB 🚨
Dependency size	0 B	2.42 MB	🚨 +2.42 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-highlight`

	Before	After	Difference
Dependency count	0	1	🚨 +1 🚨
Self size	0 B	9 KB	🚨 +9 KB 🚨
Dependency size	0 B	5 KB	🚨 +5 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-interactions`

	Before	After	Difference
Dependency count	0	56	🚨 +56 🚨
Self size	0 B	128 KB	🚨 +128 KB 🚨
Dependency size	0 B	12.73 MB	🚨 +12.73 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-jest`

	Before	After	Difference
Dependency count	0	4	🚨 +4 🚨
Self size	0 B	38 KB	🚨 +38 KB 🚨
Dependency size	0 B	84 KB	🚨 +84 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-links`

	Before	After	Difference
Dependency count	0	4	🚨 +4 🚨
Self size	0 B	19 KB	🚨 +19 KB 🚨
Dependency size	0 B	284 KB	🚨 +284 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-measure`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	32 KB	🚨 +32 KB 🚨
Dependency size	0 B	20 KB	🚨 +20 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-onboarding`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	217 KB	🚨 +217 KB 🚨
Dependency size	0 B	667 B	🚨 +667 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-outline`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	23 KB	🚨 +23 KB 🚨
Dependency size	0 B	32 KB	🚨 +32 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-storysource`

	Before	After	Difference
Dependency count	0	7	🚨 +7 🚨
Self size	0 B	1.89 MB	🚨 +1.89 MB 🚨
Dependency size	0 B	10.74 MB	🚨 +10.74 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/experimental-addon-test`

	Before	After	Difference
Dependency count	0	60	🚨 +60 🚨
Self size	0 B	832 KB	🚨 +832 KB 🚨
Dependency size	0 B	14.15 MB	🚨 +14.15 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-themes`

	Before	After	Difference
Dependency count	0	1	🚨 +1 🚨
Self size	0 B	19 KB	🚨 +19 KB 🚨
Dependency size	0 B	28 KB	🚨 +28 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-toolbars`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	10 KB	🚨 +10 KB 🚨
Dependency size	0 B	659 B	🚨 +659 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-viewport`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	27 KB	🚨 +27 KB 🚨
Dependency size	0 B	67 KB	🚨 +67 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/builder-vite`

	Before	After	Difference
Dependency count	0	6	🚨 +6 🚨
Self size	0 B	439 KB	🚨 +439 KB 🚨
Dependency size	0 B	831 KB	🚨 +831 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/builder-webpack5`

	Before	After	Difference
Dependency count	0	237	🚨 +237 🚨
Self size	0 B	80 KB	🚨 +80 KB 🚨
Dependency size	0 B	31.12 MB	🚨 +31.12 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core`

	Before	After	Difference
Dependency count	0	53	🚨 +53 🚨
Self size	0 B	19.09 MB	🚨 +19.09 MB 🚨
Dependency size	0 B	14.43 MB	🚨 +14.43 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/builder-manager`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	703 B	🚨 +703 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/channels`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	675 B	🚨 +675 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/client-logger`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	695 B	🚨 +695 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/components`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	683 B	🚨 +683 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core-common`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	687 B	🚨 +687 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core-events`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	4 KB	🚨 +4 KB 🚨
Dependency size	0 B	687 B	🚨 +687 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core-server`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	687 B	🚨 +687 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/csf-tools`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	679 B	🚨 +679 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/docs-tools`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	683 B	🚨 +683 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/manager`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	671 B	🚨 +671 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/manager-api`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	687 B	🚨 +687 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/node-logger`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	687 B	🚨 +687 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preview`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	671 B	🚨 +671 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preview-api`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	687 B	🚨 +687 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/router`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	2 KB	🚨 +2 KB 🚨
Dependency size	0 B	667 B	🚨 +667 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/telemetry`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	679 B	🚨 +679 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/theming`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	2 KB	🚨 +2 KB 🚨
Dependency size	0 B	671 B	🚨 +671 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/types`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	663 B	🚨 +663 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/angular`

	Before	After	Difference
Dependency count	0	264	🚨 +264 🚨
Self size	0 B	365 KB	🚨 +365 KB 🚨
Dependency size	0 B	33.69 MB	🚨 +33.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/ember`

	Before	After	Difference
Dependency count	0	256	🚨 +256 🚨
Self size	0 B	23 KB	🚨 +23 KB 🚨
Dependency size	0 B	31.15 MB	🚨 +31.15 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/experimental-nextjs-vite`

	Before	After	Difference
Dependency count	0	153	🚨 +153 🚨
Self size	0 B	234 KB	🚨 +234 KB 🚨
Dependency size	0 B	45.15 MB	🚨 +45.15 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html-vite`

	Before	After	Difference
Dependency count	0	15	🚨 +15 🚨
Self size	0 B	6 KB	🚨 +6 KB 🚨
Dependency size	0 B	1.91 MB	🚨 +1.91 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html-webpack5`

	Before	After	Difference
Dependency count	0	247	🚨 +247 🚨
Self size	0 B	8 KB	🚨 +8 KB 🚨
Dependency size	0 B	31.67 MB	🚨 +31.67 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	0	592	🚨 +592 🚨
Self size	0 B	474 KB	🚨 +474 KB 🚨
Dependency size	0 B	83.83 MB	🚨 +83.83 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact-vite`

	Before	After	Difference
Dependency count	0	13	🚨 +13 🚨
Self size	0 B	6 KB	🚨 +6 KB 🚨
Dependency size	0 B	1.31 MB	🚨 +1.31 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact-webpack5`

	Before	After	Difference
Dependency count	0	245	🚨 +245 🚨
Self size	0 B	8 KB	🚨 +8 KB 🚨
Dependency size	0 B	31.25 MB	🚨 +31.25 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-native-web-vite`

	Before	After	Difference
Dependency count	0	114	🚨 +114 🚨
Self size	0 B	44 KB	🚨 +44 KB 🚨
Dependency size	0 B	18.67 MB	🚨 +18.67 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-vite`

	Before	After	Difference
Dependency count	0	87	🚨 +87 🚨
Self size	0 B	14 KB	🚨 +14 KB 🚨
Dependency size	0 B	16.48 MB	🚨 +16.48 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-webpack5`

	Before	After	Difference
Dependency count	0	323	🚨 +323 🚨
Self size	0 B	8 KB	🚨 +8 KB 🚨
Dependency size	0 B	42.87 MB	🚨 +42.87 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server-webpack5`

	Before	After	Difference
Dependency count	0	255	🚨 +255 🚨
Self size	0 B	15 KB	🚨 +15 KB 🚨
Dependency size	0 B	32.65 MB	🚨 +32.65 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte-vite`

	Before	After	Difference
Dependency count	0	134	🚨 +134 🚨
Self size	0 B	23 KB	🚨 +23 KB 🚨
Dependency size	0 B	36.38 MB	🚨 +36.38 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte-webpack5`

	Before	After	Difference
Dependency count	0	310	🚨 +310 🚨
Self size	0 B	7 KB	🚨 +7 KB 🚨
Dependency size	0 B	39.24 MB	🚨 +39.24 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/sveltekit`

	Before	After	Difference
Dependency count	0	142	🚨 +142 🚨
Self size	0 B	48 KB	🚨 +48 KB 🚨
Dependency size	0 B	39.68 MB	🚨 +39.68 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3-vite`

	Before	After	Difference
Dependency count	0	108	🚨 +108 🚨
Self size	0 B	17 KB	🚨 +17 KB 🚨
Dependency size	0 B	42.58 MB	🚨 +42.58 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3-webpack5`

	Before	After	Difference
Dependency count	0	495	🚨 +495 🚨
Self size	0 B	7 KB	🚨 +7 KB 🚨
Dependency size	0 B	55.64 MB	🚨 +55.64 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components-vite`

	Before	After	Difference
Dependency count	0	16	🚨 +16 🚨
Self size	0 B	7 KB	🚨 +7 KB 🚨
Dependency size	0 B	1.94 MB	🚨 +1.94 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components-webpack5`

	Before	After	Difference
Dependency count	0	245	🚨 +245 🚨
Self size	0 B	7 KB	🚨 +7 KB 🚨
Dependency size	0 B	31.29 MB	🚨 +31.29 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/blocks`

	Before	After	Difference
Dependency count	0	4	🚨 +4 🚨
Self size	0 B	604 KB	🚨 +604 KB 🚨
Dependency size	0 B	1.49 MB	🚨 +1.49 MB 🚨
Bundle Size Analyzer	Link	Link

`storybook`

	Before	After	Difference
Dependency count	0	54	🚨 +54 🚨
Self size	0 B	22 KB	🚨 +22 KB 🚨
Dependency size	0 B	33.53 MB	🚨 +33.53 MB 🚨
Bundle Size Analyzer	Link	Link

`sb`

	Before	After	Difference
Dependency count	0	55	🚨 +55 🚨
Self size	0 B	1 KB	🚨 +1 KB 🚨
Dependency size	0 B	33.55 MB	🚨 +33.55 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	0	398	🚨 +398 🚨
Self size	0 B	503 KB	🚨 +503 KB 🚨
Dependency size	0 B	75.58 MB	🚨 +75.58 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	0	276	🚨 +276 🚨
Self size	0 B	617 KB	🚨 +617 KB 🚨
Dependency size	0 B	65.37 MB	🚨 +65.37 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core-webpack`

	Before	After	Difference
Dependency count	0	1	🚨 +1 🚨
Self size	0 B	16 KB	🚨 +16 KB 🚨
Dependency size	0 B	28 KB	🚨 +28 KB 🚨
Bundle Size Analyzer	Link	Link

`create-storybook`

	Before	After	Difference
Dependency count	0	112	🚨 +112 🚨
Self size	0 B	1.11 MB	🚨 +1.11 MB 🚨
Dependency size	0 B	42.66 MB	🚨 +42.66 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/csf-plugin`

	Before	After	Difference
Dependency count	0	3	🚨 +3 🚨
Self size	0 B	10 KB	🚨 +10 KB 🚨
Dependency size	0 B	788 KB	🚨 +788 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/instrumenter`

	Before	After	Difference
Dependency count	0	5	🚨 +5 🚨
Self size	0 B	221 KB	🚨 +221 KB 🚨
Dependency size	0 B	278 KB	🚨 +278 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-dom-shim`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	10 KB	🚨 +10 KB 🚨
Dependency size	0 B	795 B	🚨 +795 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/source-loader`

	Before	After	Difference
Dependency count	0	5	🚨 +5 🚨
Self size	0 B	41 KB	🚨 +41 KB 🚨
Dependency size	0 B	10.68 MB	🚨 +10.68 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/test`

	Before	After	Difference
Dependency count	0	53	🚨 +53 🚨
Self size	0 B	1.82 MB	🚨 +1.82 MB 🚨
Dependency size	0 B	8.09 MB	🚨 +8.09 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-create-react-app`

	Before	After	Difference
Dependency count	0	68	🚨 +68 🚨
Self size	0 B	18 KB	🚨 +18 KB 🚨
Dependency size	0 B	6.04 MB	🚨 +6.04 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-html-webpack`

	Before	After	Difference
Dependency count	0	102	🚨 +102 🚨
Self size	0 B	4 KB	🚨 +4 KB 🚨
Dependency size	0 B	22.72 MB	🚨 +22.72 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-preact-webpack`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	5 KB	🚨 +5 KB 🚨
Dependency size	0 B	44 KB	🚨 +44 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-react-webpack`

	Before	After	Difference
Dependency count	0	191	🚨 +191 🚨
Self size	0 B	24 KB	🚨 +24 KB 🚨
Dependency size	0 B	33.94 MB	🚨 +33.94 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-server-webpack`

	Before	After	Difference
Dependency count	0	18	🚨 +18 🚨
Self size	0 B	10 KB	🚨 +10 KB 🚨
Dependency size	0 B	1.48 MB	🚨 +1.48 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-svelte-webpack`

	Before	After	Difference
Dependency count	0	101	🚨 +101 🚨
Self size	0 B	14 KB	🚨 +14 KB 🚨
Dependency size	0 B	10.40 MB	🚨 +10.40 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-vue3-webpack`

	Before	After	Difference
Dependency count	0	375	🚨 +375 🚨
Self size	0 B	9 KB	🚨 +9 KB 🚨
Dependency size	0 B	47.62 MB	🚨 +47.62 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html`

	Before	After	Difference
Dependency count	0	6	🚨 +6 🚨
Self size	0 B	47 KB	🚨 +47 KB 🚨
Dependency size	0 B	40 KB	🚨 +40 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact`

	Before	After	Difference
Dependency count	0	6	🚨 +6 🚨
Self size	0 B	23 KB	🚨 +23 KB 🚨
Dependency size	0 B	40 KB	🚨 +40 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react`

	Before	After	Difference
Dependency count	0	6	🚨 +6 🚨
Self size	0 B	1.36 MB	🚨 +1.36 MB 🚨
Dependency size	0 B	24 KB	🚨 +24 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server`

	Before	After	Difference
Dependency count	0	9	🚨 +9 🚨
Self size	0 B	13 KB	🚨 +13 KB 🚨
Dependency size	0 B	974 KB	🚨 +974 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte`

	Before	After	Difference
Dependency count	0	106	🚨 +106 🚨
Self size	0 B	96 KB	🚨 +96 KB 🚨
Dependency size	0 B	10.59 MB	🚨 +10.59 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3`

	Before	After	Difference
Dependency count	0	17	🚨 +17 🚨
Self size	0 B	87 KB	🚨 +87 KB 🚨
Dependency size	0 B	6.11 MB	🚨 +6.11 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components`

	Before	After	Difference
Dependency count	0	7	🚨 +7 🚨
Self size	0 B	62 KB	🚨 +62 KB 🚨
Dependency size	0 B	55 KB	🚨 +55 KB 🚨
Bundle Size Analyzer	Link	Link

yannbf added feature request core typescript ci:normal labels Jan 13, 2025

yannbf self-assigned this Jan 13, 2025

greptile-apps bot reviewed Jan 13, 2025

View reviewed changes

yannbf changed the base branch from kasper/csf-factories to yann/csf-factories-base January 13, 2025 13:46

yannbf changed the title ~~Add defineConfig helper for main.js~~ Core: Add defineConfig helper for main.js Jan 13, 2025

yannbf force-pushed the yann/csf-factories-extra branch from e280ec0 to b181f27 Compare January 14, 2025 15:52

yannbf force-pushed the yann/csf-factories-base branch from 1820f5d to 4f56d4f Compare January 17, 2025 11:16

yannbf force-pushed the yann/csf-factories-extra branch from b181f27 to 45864f1 Compare January 17, 2025 11:35

yannbf force-pushed the yann/csf-factories-base branch from 4f56d4f to 61c97c0 Compare January 17, 2025 12:02

yannbf force-pushed the yann/csf-factories-extra branch from 45864f1 to cc0361d Compare January 17, 2025 12:09

yannbf force-pushed the yann/csf-factories-base branch from 61c97c0 to 659930e Compare January 17, 2025 12:17

yannbf added 4 commits January 17, 2025 13:17

Add defineConfig helper for main.js

7db0050

move defineConfig to its own import path

ebe6bf9

fix internal type import

df000bb

rename the import and function

5ac85ef

yannbf force-pushed the yann/csf-factories-extra branch from cc0361d to 5ac85ef Compare January 17, 2025 12:23

fix angular and ember build

9df03e6

yannbf merged commit 503f883 into yann/csf-factories-base Jan 17, 2025
53 of 57 checks passed

yannbf deleted the yann/csf-factories-extra branch January 17, 2025 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core: Add defineConfig helper for main.js #30250

Core: Add defineConfig helper for main.js #30250

yannbf commented Jan 13, 2025 •

edited by storybook-pr-benchmarking bot

Loading

nx-cloud bot commented Jan 13, 2025 •

edited

Loading

greptile-apps bot left a comment

storybook-pr-benchmarking bot commented Jan 17, 2025 •

edited

Loading

Core: Add defineConfig helper for main.js #30250

Core: Add defineConfig helper for main.js #30250

Conversation

yannbf commented Jan 13, 2025 • edited by storybook-pr-benchmarking bot Loading

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Greptile Summary

nx-cloud bot commented Jan 13, 2025 • edited Loading

greptile-apps bot left a comment

Choose a reason for hiding this comment

storybook-pr-benchmarking bot commented Jan 17, 2025 • edited Loading

Package Benchmarks

@storybook/addon-a11y

@storybook/addon-actions

@storybook/addon-backgrounds

@storybook/addon-controls

@storybook/addon-docs

@storybook/addon-essentials

@storybook/addon-mdx-gfm

@storybook/addon-highlight

@storybook/addon-interactions

@storybook/addon-jest

@storybook/addon-links

@storybook/addon-measure

@storybook/addon-onboarding

@storybook/addon-outline

@storybook/addon-storysource

@storybook/experimental-addon-test

@storybook/addon-themes

@storybook/addon-toolbars

@storybook/addon-viewport

@storybook/builder-vite

@storybook/builder-webpack5

@storybook/core

@storybook/builder-manager

@storybook/channels

@storybook/client-logger

@storybook/components

@storybook/core-common

@storybook/core-events

@storybook/core-server

@storybook/csf-tools

@storybook/docs-tools

@storybook/manager

@storybook/manager-api

@storybook/node-logger

@storybook/preview

@storybook/preview-api

@storybook/router

@storybook/telemetry

@storybook/theming

@storybook/types

@storybook/angular

@storybook/ember

@storybook/experimental-nextjs-vite

@storybook/html-vite

@storybook/html-webpack5

@storybook/nextjs

@storybook/preact-vite

@storybook/preact-webpack5

@storybook/react-native-web-vite

@storybook/react-vite

@storybook/react-webpack5

@storybook/server-webpack5

@storybook/svelte-vite

@storybook/svelte-webpack5

@storybook/sveltekit

@storybook/vue3-vite

@storybook/vue3-webpack5

@storybook/web-components-vite

@storybook/web-components-webpack5

@storybook/blocks

storybook

sb

yannbf commented Jan 13, 2025 •

edited by storybook-pr-benchmarking bot

Loading

nx-cloud bot commented Jan 13, 2025 •

edited

Loading

storybook-pr-benchmarking bot commented Jan 17, 2025 •

edited

Loading

`@storybook/addon-a11y`

`@storybook/addon-actions`

`@storybook/addon-backgrounds`

`@storybook/addon-controls`

`@storybook/addon-docs`

`@storybook/addon-essentials`

`@storybook/addon-mdx-gfm`

`@storybook/addon-highlight`

`@storybook/addon-interactions`

`@storybook/addon-jest`

`@storybook/addon-links`

`@storybook/addon-measure`

`@storybook/addon-onboarding`

`@storybook/addon-outline`

`@storybook/addon-storysource`

`@storybook/experimental-addon-test`

`@storybook/addon-themes`

`@storybook/addon-toolbars`

`@storybook/addon-viewport`

`@storybook/builder-vite`

`@storybook/builder-webpack5`

`@storybook/core`

`@storybook/builder-manager`

`@storybook/channels`

`@storybook/client-logger`

`@storybook/components`

`@storybook/core-common`

`@storybook/core-events`

`@storybook/core-server`

`@storybook/csf-tools`

`@storybook/docs-tools`

`@storybook/manager`

`@storybook/manager-api`

`@storybook/node-logger`

`@storybook/preview`

`@storybook/preview-api`

`@storybook/router`

`@storybook/telemetry`

`@storybook/theming`

`@storybook/types`

`@storybook/angular`

`@storybook/ember`

`@storybook/experimental-nextjs-vite`

`@storybook/html-vite`

`@storybook/html-webpack5`

`@storybook/nextjs`

`@storybook/preact-vite`

`@storybook/preact-webpack5`

`@storybook/react-native-web-vite`

`@storybook/react-vite`

`@storybook/react-webpack5`

`@storybook/server-webpack5`

`@storybook/svelte-vite`

`@storybook/svelte-webpack5`

`@storybook/sveltekit`

`@storybook/vue3-vite`

`@storybook/vue3-webpack5`

`@storybook/web-components-vite`

`@storybook/web-components-webpack5`

`@storybook/blocks`

`storybook`

`sb`

`@storybook/cli`

`@storybook/codemod`

`@storybook/core-webpack`

`create-storybook`

`@storybook/csf-plugin`

`@storybook/instrumenter`

`@storybook/react-dom-shim`

`@storybook/source-loader`

`@storybook/test`

`@storybook/preset-create-react-app`

`@storybook/preset-html-webpack`

`@storybook/preset-preact-webpack`

`@storybook/preset-react-webpack`

`@storybook/preset-server-webpack`

`@storybook/preset-svelte-webpack`