-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react native Typescript transform #3209
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3b6003a
Added a cli flag to allow passing custom config to the metro bundler
cliedeman 6ec9237
Bootstrapped new react-native project and added typescript support
cliedeman e22e1a3
Added storybook
cliedeman ad8948a
Merge branch 'master' into typescript-transform
ndelangen c854d15
Merge branch 'master' into typescript-transform
Hypnosphi a5fd30e
Deleted flowconfig
cliedeman 477d0cc
Added bootstrap for react-native typescript
cliedeman e13f983
Fixed folder name
cliedeman 09354ff
Implemented storyshots
cliedeman 3c528a8
Add lerna disabled
cliedeman 098c664
Merge branch 'master' into typescript-transform
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"presets": ["react-native"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
[android] | ||
target = Google Inc.:Google APIs:23 | ||
|
||
[maven_repositories] | ||
central = https://repo1.maven.org/maven2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
[ignore] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need to configure Flow in a Typescript project? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. part of the react-native boilerplate. will delete |
||
; We fork some components by platform | ||
.*/*[.]android.js | ||
|
||
; Ignore "BUCK" generated dirs | ||
<PROJECT_ROOT>/\.buckd/ | ||
|
||
; Ignore unexpected extra "@providesModule" | ||
.*/node_modules/.*/node_modules/fbjs/.* | ||
|
||
; Ignore duplicate module providers | ||
; For RN Apps installed via npm, "Libraries" folder is inside | ||
; "node_modules/react-native" but in the source repo it is in the root | ||
.*/Libraries/react-native/React.js | ||
|
||
; Ignore polyfills | ||
.*/Libraries/polyfills/.* | ||
|
||
; Ignore metro | ||
.*/node_modules/metro/.* | ||
|
||
[include] | ||
|
||
[libs] | ||
node_modules/react-native/Libraries/react-native/react-native-interface.js | ||
node_modules/react-native/flow/ | ||
node_modules/react-native/flow-github/ | ||
|
||
[options] | ||
emoji=true | ||
|
||
module.system=haste | ||
|
||
munge_underscores=true | ||
|
||
module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub' | ||
|
||
module.file_ext=.js | ||
module.file_ext=.jsx | ||
module.file_ext=.json | ||
module.file_ext=.native.js | ||
|
||
suppress_type=$FlowIssue | ||
suppress_type=$FlowFixMe | ||
suppress_type=$FlowFixMeProps | ||
suppress_type=$FlowFixMeState | ||
|
||
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\) | ||
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+ | ||
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy | ||
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError | ||
|
||
[version] | ||
^0.65.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.pbxproj -text |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# OSX | ||
# | ||
.DS_Store | ||
|
||
# Xcode | ||
# | ||
build/ | ||
*.pbxuser | ||
!default.pbxuser | ||
*.mode1v3 | ||
!default.mode1v3 | ||
*.mode2v3 | ||
!default.mode2v3 | ||
*.perspectivev3 | ||
!default.perspectivev3 | ||
xcuserdata | ||
*.xccheckout | ||
*.moved-aside | ||
DerivedData | ||
*.hmap | ||
*.ipa | ||
*.xcuserstate | ||
project.xcworkspace | ||
|
||
# Android/IntelliJ | ||
# | ||
build/ | ||
.idea | ||
.gradle | ||
local.properties | ||
*.iml | ||
|
||
# node.js | ||
# | ||
node_modules/ | ||
npm-debug.log | ||
yarn-error.log | ||
.jest | ||
|
||
# BUCK | ||
buck-out/ | ||
\.buckd/ | ||
*.keystore | ||
|
||
# fastlane | ||
# | ||
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the | ||
# screenshots whenever they are needed. | ||
# For more information about the recommended setup visit: | ||
# https://docs.fastlane.tools/best-practices/source-control/ | ||
|
||
*/fastlane/report.xml | ||
*/fastlane/Preview.html | ||
*/fastlane/screenshots |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
# To learn about Buck see [Docs](https://buckbuild.com/). | ||
# To run your application with Buck: | ||
# - install Buck | ||
# - `npm start` - to start the packager | ||
# - `cd android` | ||
# - `keytool -genkey -v -keystore keystores/debug.keystore -storepass android -alias androiddebugkey -keypass android -dname "CN=Android Debug,O=Android,C=US"` | ||
# - `./gradlew :app:copyDownloadableDepsToLibs` - make all Gradle compile dependencies available to Buck | ||
# - `buck install -r android/app` - compile, install and run application | ||
# | ||
|
||
lib_deps = [] | ||
|
||
for jarfile in glob(['libs/*.jar']): | ||
name = 'jars__' + jarfile[jarfile.rindex('/') + 1: jarfile.rindex('.jar')] | ||
lib_deps.append(':' + name) | ||
prebuilt_jar( | ||
name = name, | ||
binary_jar = jarfile, | ||
) | ||
|
||
for aarfile in glob(['libs/*.aar']): | ||
name = 'aars__' + aarfile[aarfile.rindex('/') + 1: aarfile.rindex('.aar')] | ||
lib_deps.append(':' + name) | ||
android_prebuilt_aar( | ||
name = name, | ||
aar = aarfile, | ||
) | ||
|
||
android_library( | ||
name = "all-libs", | ||
exported_deps = lib_deps, | ||
) | ||
|
||
android_library( | ||
name = "app-code", | ||
srcs = glob([ | ||
"src/main/java/**/*.java", | ||
]), | ||
deps = [ | ||
":all-libs", | ||
":build_config", | ||
":res", | ||
], | ||
) | ||
|
||
android_build_config( | ||
name = "build_config", | ||
package = "com.reactnativetypescript", | ||
) | ||
|
||
android_resource( | ||
name = "res", | ||
package = "com.reactnativetypescript", | ||
res = "src/main/res", | ||
) | ||
|
||
android_binary( | ||
name = "app", | ||
keystore = "//android/keystores:debug", | ||
manifest = "src/main/AndroidManifest.xml", | ||
package_type = "debug", | ||
deps = [ | ||
":app-code", | ||
], | ||
) |
150 changes: 150 additions & 0 deletions
150
examples/react-native-typesript/android/app/build.gradle
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
apply plugin: "com.android.application" | ||
|
||
import com.android.build.OutputFile | ||
|
||
/** | ||
* The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets | ||
* and bundleReleaseJsAndAssets). | ||
* These basically call `react-native bundle` with the correct arguments during the Android build | ||
* cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the | ||
* bundle directly from the development server. Below you can see all the possible configurations | ||
* and their defaults. If you decide to add a configuration block, make sure to add it before the | ||
* `apply from: "../../node_modules/react-native/react.gradle"` line. | ||
* | ||
* project.ext.react = [ | ||
* // the name of the generated asset file containing your JS bundle | ||
* bundleAssetName: "index.android.bundle", | ||
* | ||
* // the entry file for bundle generation | ||
* entryFile: "index.android.js", | ||
* | ||
* // whether to bundle JS and assets in debug mode | ||
* bundleInDebug: false, | ||
* | ||
* // whether to bundle JS and assets in release mode | ||
* bundleInRelease: true, | ||
* | ||
* // whether to bundle JS and assets in another build variant (if configured). | ||
* // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants | ||
* // The configuration property can be in the following formats | ||
* // 'bundleIn${productFlavor}${buildType}' | ||
* // 'bundleIn${buildType}' | ||
* // bundleInFreeDebug: true, | ||
* // bundleInPaidRelease: true, | ||
* // bundleInBeta: true, | ||
* | ||
* // whether to disable dev mode in custom build variants (by default only disabled in release) | ||
* // for example: to disable dev mode in the staging build type (if configured) | ||
* devDisabledInStaging: true, | ||
* // The configuration property can be in the following formats | ||
* // 'devDisabledIn${productFlavor}${buildType}' | ||
* // 'devDisabledIn${buildType}' | ||
* | ||
* // the root of your project, i.e. where "package.json" lives | ||
* root: "../../", | ||
* | ||
* // where to put the JS bundle asset in debug mode | ||
* jsBundleDirDebug: "$buildDir/intermediates/assets/debug", | ||
* | ||
* // where to put the JS bundle asset in release mode | ||
* jsBundleDirRelease: "$buildDir/intermediates/assets/release", | ||
* | ||
* // where to put drawable resources / React Native assets, e.g. the ones you use via | ||
* // require('./image.png')), in debug mode | ||
* resourcesDirDebug: "$buildDir/intermediates/res/merged/debug", | ||
* | ||
* // where to put drawable resources / React Native assets, e.g. the ones you use via | ||
* // require('./image.png')), in release mode | ||
* resourcesDirRelease: "$buildDir/intermediates/res/merged/release", | ||
* | ||
* // by default the gradle tasks are skipped if none of the JS files or assets change; this means | ||
* // that we don't look at files in android/ or ios/ to determine whether the tasks are up to | ||
* // date; if you have any other folders that you want to ignore for performance reasons (gradle | ||
* // indexes the entire tree), add them here. Alternatively, if you have JS files in android/ | ||
* // for example, you might want to remove it from here. | ||
* inputExcludes: ["android/**", "ios/**"], | ||
* | ||
* // override which node gets called and with what additional arguments | ||
* nodeExecutableAndArgs: ["node"], | ||
* | ||
* // supply additional arguments to the packager | ||
* extraPackagerArgs: [] | ||
* ] | ||
*/ | ||
|
||
project.ext.react = [ | ||
entryFile: "index.js" | ||
] | ||
|
||
apply from: "../../node_modules/react-native/react.gradle" | ||
|
||
/** | ||
* Set this to true to create two separate APKs instead of one: | ||
* - An APK that only works on ARM devices | ||
* - An APK that only works on x86 devices | ||
* The advantage is the size of the APK is reduced by about 4MB. | ||
* Upload all the APKs to the Play Store and people will download | ||
* the correct one based on the CPU architecture of their device. | ||
*/ | ||
def enableSeparateBuildPerCPUArchitecture = false | ||
|
||
/** | ||
* Run Proguard to shrink the Java bytecode in release builds. | ||
*/ | ||
def enableProguardInReleaseBuilds = false | ||
|
||
android { | ||
compileSdkVersion 23 | ||
buildToolsVersion "23.0.1" | ||
|
||
defaultConfig { | ||
applicationId "com.reactnativetypescript" | ||
minSdkVersion 16 | ||
targetSdkVersion 22 | ||
versionCode 1 | ||
versionName "1.0" | ||
ndk { | ||
abiFilters "armeabi-v7a", "x86" | ||
} | ||
} | ||
splits { | ||
abi { | ||
reset() | ||
enable enableSeparateBuildPerCPUArchitecture | ||
universalApk false // If true, also generate a universal APK | ||
include "armeabi-v7a", "x86" | ||
} | ||
} | ||
buildTypes { | ||
release { | ||
minifyEnabled enableProguardInReleaseBuilds | ||
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro" | ||
} | ||
} | ||
// applicationVariants are e.g. debug, release | ||
applicationVariants.all { variant -> | ||
variant.outputs.each { output -> | ||
// For each separate APK per architecture, set a unique version code as described here: | ||
// http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits | ||
def versionCodes = ["armeabi-v7a":1, "x86":2] | ||
def abi = output.getFilter(OutputFile.ABI) | ||
if (abi != null) { // null for the universal-debug, universal-release variants | ||
output.versionCodeOverride = | ||
versionCodes.get(abi) * 1048576 + defaultConfig.versionCode | ||
} | ||
} | ||
} | ||
} | ||
|
||
dependencies { | ||
compile fileTree(dir: "libs", include: ["*.jar"]) | ||
compile "com.android.support:appcompat-v7:23.0.1" | ||
compile "com.facebook.react:react-native:+" // From node_modules | ||
} | ||
|
||
// Run this once to be able to run the application with BUCK | ||
// puts all compile dependencies into folder libs for BUCK to use | ||
task copyDownloadableDepsToLibs(type: Copy) { | ||
from configurations.compile | ||
into 'libs' | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make it work with haul? This variable is reassigned when using it (see below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For haul according to the docs you just modify the generated webpack.haul.js file for typescript