Add support for [email protected]

[mrmckeb]

Issue: facebook/create-react-app#6656

What I did

create-react-app@3 is likely to be released next week, and adds support for baseUrl in tsconfig.json and jsconfig.json files. Users will be told that NODE_PATH is deprecated, although it'll still work for now.

We want to make sure that users that do remove NODE_PATH don't find that their Storybook no longer works as expected.

How to test

• Is this testable with Jest or Chromatic screenshots? No
• Does this need a new example in the kitchen sink apps? No
• Does this need an update to the documentation? No

This can be tested by installing alongside the latest next release with the --typescript flag.
https://www.npmjs.com/package/create-react-app/v/3.0.0-next.68

After installation, add the property baseUrl with the value src to the project's tsconfig.json.

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-feature-support-cra-baseurl.storybook.now.sh

[ndelangen]

Wow amazing @mrmckeb

[codecov]

Codecov Report

Merging #6560 into next will increase coverage by 0.13%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             next    #6560      +/-   ##
==========================================
+ Coverage   40.69%   40.82%   +0.13%     
==========================================
  Files         616      616              
  Lines        8534     8541       +7     
  Branches      600      595       -5     
==========================================
+ Hits         3473     3487      +14     
+ Misses       4972     4962      -10     
- Partials       89       92       +3

Impacted Files	Coverage Δ
app/react/src/server/cra-config.js	85.52% <76.92%> (-1.98%)	⬇️
lib/ui/src/components/layout/desktop.js	100% <0%> (ø)	⬆️
...-native/src/preview/components/StoryView/index.tsx	0% <0%> (ø)	⬆️
addons/storysource/src/manager.js	0% <0%> (ø)	⬆️
lib/api/src/modules/layout.ts	46.47% <0%> (+9.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f93649...c122019. Read the comment docs.

[mrmckeb]

This is ready for review @ndelangen, I'd just like to hold off merging until I can test with the final release.

[shilman]

LGTM, thanks for taking care of this 🎖

[pavinthan]

but this changes is not working for latest CRA app:
This is my jsconfig.json

{
  "compilerOptions": {
    "baseUrl": "src"
  },
  "include": ["src"]
}

This is my component

...
import { name } from "config/env";
...

I got this error when I start storybook

ERROR in ./src/components/DocumentHead/index.js
Module not found: Error: Can't resolve 'config/env' in '/Users/pavinthan/code/projects/deliver-daily/kpi-client/src/components/DocumentHead'

[mrmckeb]

@pavinthan, can you share a reproduction of this issue? I can take a look for you :)

[Hypnosphi]

@pavinthan it should be fixed with #9324

[pavinthan]

@mrmckeb I'm really very sorry becase I did not check this, I just skiped and thanks for your actions guys 🙏 🙏 🙏

// cc @Hypnosphi

[mrmckeb]

No problem, thanks for the feedback!