Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Upgrade from node8 to node10 #8207

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Build: Upgrade from node8 to node10 #8207

merged 2 commits into from
Sep 26, 2019

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Sep 26, 2019 •
edited
Loading

Issue: #8173

because we want: #7747

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Sep 26, 2019
@ndelangen ndelangen added this to the 5.3.0 milestone Sep 26, 2019
@ndelangen ndelangen requested a review from kroeder September 26, 2019 10:20
@ndelangen ndelangen self-assigned this Sep 26, 2019
@vercel
Copy link

vercel bot commented Sep 26, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-run-node10-in-ci.storybook.now.sh

@ndelangen ndelangen changed the title CHANGE circleCI to use node10 CHANGE CI to use node10 Sep 26, 2019
@shilman shilman changed the title CHANGE CI to use node10 Build: Upgrade from node8 to node10 Sep 26, 2019
shilman
shilman approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman merged commit f7367b1 into next Sep 26, 2019
@shilman shilman deleted the tech/run-node10-in-ci branch September 26, 2019 20:41
@shilman
Copy link
Member

shilman commented Sep 26, 2019

@ndelangen do we also need to change anything about "engine" in package.json?

@ndelangen
Copy link
Member Author

We may, I think it's fair to do so at 1st of January next year when Node 8 exits LTS

@shilman shilman mentioned this pull request Sep 27, 2019
Closed
@phated phated mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@kroeder kroeder Awaiting requested review from kroeder

@atanasster atanasster Awaiting requested review from atanasster

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman