Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Upgrade babel-plugin-react-docgen to 4.0.0 #9303

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 2, 2020

Issue: N/A

What I did

How to test

See Docs pages for React sample apps:

  • official-storybook
  • cra-*

@vercel
Copy link

vercel bot commented Jan 2, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/5hgyvvr9e
✅ Preview: https://monorepo-git-react-upgrade-babel-plugin-react-docgen.storybook.now.sh

@patricklafrance
Copy link
Member

Here's what I have so far.

I only tested with PropTypes... none of our bugs have been fixed but I can't find any regression... So far so good.

  • All addon-docs 302 Jest tests passed
  • React.forwardRef & React.memo still doesn't seems to work. Was not working before either.
  • Storybook Official props table for PropTypes looks fine.
  • cra-ts-kitchen-sink
    -> JSDoc still works
    -> All prop types still works
    -> react-docgen still doesn't support spreaded defaultProps
    -> react-docgen still doesn't support imported object
    -> react-docgen still doesn't respect the props original sort order. Props will a default value are still always first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants