Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #9644

Closed
wants to merge 1 commit into from
Closed

Update index.md #9644

wants to merge 1 commit into from

Conversation

avihaym
Copy link

@avihaym avihaym commented Jan 27, 2020

Add comment about render function with Vue (need to pass h variable to avoid error).

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Add comment about render function with Vue (need to pass h variable to avoid error).
@vercel
Copy link

vercel bot commented Jan 27, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/idjcka4p3
✅ Preview: https://monorepo-git-fork-avihaym-patch-3.storybook.now.sh

@@ -92,6 +92,17 @@ addons.register(ADDON_ID, api => {
});
});
```
#### Note:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aaron-Pool is this required, or is this an issue of mis-configuration in @avihaym's project? I'm a little suspicious.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on the JSX preset/settings being used by whatever is compiling this. Theoretically h should be auto-injected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aaron-Pool this is an addon, so these files should be treated as react, not Vue AFAIK

Possibly related? #9648
cc @ndelangen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this i`m getting "Uncaught ReferenceError: h is not defined"

Copy link
Member

@shilman shilman Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avihaym I understand that this fixes the warning for you. That doesn't necessarily make it the correct fix. Adding it to the documentation makes it sound like it's the recommended workaround, but I suspect it's more likely that your project is misconfigured. Thanks for your patience while we work this out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after playing with this hack its not really working...
I mange to add myAddon tab to panel but the div inside not showing.
I create a new react app and its working with the same code in register.js.

So maybe just add to the docs that is not supprt Vue yet...
Thanks for your patience.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's close this PR.

I hope you can assist us with testing #9648 @avihaym

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when you finish... i will try to help you :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome guys 🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll ping you when the PR is in an alpha release.

Might take a week, since @shilman is currently performing very important research in the field. 🏖

@ndelangen ndelangen closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants