-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md #9644
Update index.md #9644
Conversation
Add comment about render function with Vue (need to pass h variable to avoid error).
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/idjcka4p3 |
@@ -92,6 +92,17 @@ addons.register(ADDON_ID, api => { | |||
}); | |||
}); | |||
``` | |||
#### Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aaron-Pool is this required, or is this an issue of mis-configuration in @avihaym's project? I'm a little suspicious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on the JSX preset/settings being used by whatever is compiling this. Theoretically h
should be auto-injected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aaron-Pool this is an addon, so these files should be treated as react, not Vue AFAIK
Possibly related? #9648
cc @ndelangen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this i`m getting "Uncaught ReferenceError: h is not defined"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avihaym I understand that this fixes the warning for you. That doesn't necessarily make it the correct fix. Adding it to the documentation makes it sound like it's the recommended workaround, but I suspect it's more likely that your project is misconfigured. Thanks for your patience while we work this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after playing with this hack its not really working...
I mange to add myAddon tab to panel but the div inside not showing.
I create a new react app and its working with the same code in register.js.
So maybe just add to the docs that is not supprt Vue yet...
Thanks for your patience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when you finish... i will try to help you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome guys 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll ping you when the PR is in an alpha release.
Might take a week, since @shilman is currently performing very important research in the field. 🏖
Add comment about render function with Vue (need to pass h variable to avoid error).
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.