Core: Fix manager assets to be routed in express #9646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies over preview) namechange the webpackDevMiddleWare to preview... for clarity
…utomatically, we no longer need this.
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
shilman
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
LGTM, great job! but what's up with the deepscan issues @ndelangen ?
# Conflicts: # lib/core/src/server/dev-server.js
|
Should be fixed now @shilman |
shilman
changed the title
shilman
changed the title
|
@ndelangen do you think it's safe to patch this back to |
|
Yes, I think this is safe to port to 5.3 really. |
|
Please port back to 5.3! |
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Mar 31, 2020
Core: Fix manager assets to be routed in express
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9443
What I did
I changed the way the manager webpack process starts/watches. By doing this it's possible to add all the webpack routes to express.
This was already the way preview works.