Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on AsyncStorage section #9885

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

gaguirre
Copy link
Contributor

@gaguirre gaguirre commented Feb 17, 2020

Issue: In the AsyncStorage section of the docs, there is a typo on the require causing the AsyncStorage from react-native-community to be never used.

What I did

Fix that typo.

How to test

  • ✖️Is this testable with Jest or Chromatic screenshots?
  • ✖️Does this need a new example in the kitchen sink apps?
  • ✅Does this need an update to the documentation?

Despite it's just a change in the docs, it can be tested by checking there is no warning when using the AsyncStorage from react-native-community

const StorybookUIRoot = getStorybookUI({
  asyncStorage: require('@react-native-community/async-storage').default,
})

Versus following the previous doc, which will cause a warning

const StorybookUIRoot = getStorybookUI({
  asyncStorage: require('@react-native-community/async-storage').AsyncStorage,
})

Note: I can't set a documentation label as suggested

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 17, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!! 🙏

@shilman shilman merged commit b95bc58 into storybookjs:next Feb 17, 2020
@gaguirre gaguirre deleted the patch-3 branch February 17, 2020 19:09
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 25, 2020
shilman added a commit that referenced this pull request Feb 25, 2020
Fix typo on AsyncStorage section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants