This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo formatting. merging this to get things unstuck.
shilman
suggested changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the following errors when I run locally:
MMBP15:testing-library shilman$ yarn build
yarn run v1.22.11
$ tsc
node_modules/@storybook/addons/dist/ts3.9/types.d.ts:1:23 - error TS2688: Cannot find type definition file for 'webpack-env'.
1 /// <reference types="webpack-env" />
~~~~~~~~~~~
src/index.ts:12:5 - error TS2345: Argument of type '{ intercept: (method: string, path: (string | CallRef)[]) => boolean; getArgs: (call: any, state: any) => any; }' is not assignable to parameter of type 'Options'.
Object literal may only specify known properties, and 'getArgs' does not exist in type 'Options'.
12 getArgs: (call, state) => {
~~~~~~~~~~~~~~~~~~~~~~~~~~~
13 if (!state.isDebugging) return call.args
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
26 return call.args
~~~~~~~~~~~~~~~~~~~~~~
27 },
~~~~~
src/index.ts:12:15 - error TS7006: Parameter 'call' implicitly has an 'any' type.
12 getArgs: (call, state) => {
~~~~
src/index.ts:12:21 - error TS7006: Parameter 'state' implicitly has an 'any' type.
12 getArgs: (call, state) => {
fixed! |
ndelangen
approved these changes
Oct 12, 2021
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.