Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce RoyaltyTokenDistributionWorkflows to main for royalty token distribution upon IP registration #136

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

sebsadface
Copy link
Member

@sebsadface sebsadface commented Dec 3, 2024

Description

This PR introduces RoyaltyTokenDistributionWorkflows to the main branch, along with several enhancements to its functionality. These changes build upon the version introduced in release-v1.2.4 in #126 for periphery v1.2.

Key Changes

  • Eliminated the need to pay extra license minting fees during IP royalty vault deployment. Achieved this by attaching a temporary commercial-use license with a minting fee of 0 and disabling the license immediately after deployment.
  • Leveraged setBatchPermission to reduce signature requirements. All functions now require at most one signature from the user.
  • Integrated the latest protocol core API.
  • Added the ability to set licensing configurations during license attachment.

Test Plan

Modified the existing tests to align with the changes, and all tests pass locally.

Related Issue

@sebsadface sebsadface merged commit 1035fe5 into storyprotocol:main Dec 3, 2024
3 checks passed
@sebsadface sebsadface deleted the rt-distribute branch December 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants