feat(royalty): remove currencyTokens parameter and extract internally in batch claim functions
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
- Catch and handle `IpRoyaltyVault__NoClaimableTokens` error. - Revert with original error for all other cases using assembly. - Existing tests already covers the non-revert case - Added tests to cover the revert case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the enhancement proposed in PR #74 by removing the
currencyTokensparameter from the methodstransferToVaultAndSnapshotAndClaimByTokenBatchandtransferToVaultAndSnapshotAndClaimBySnapshotBatch. The functions now internally extract the list of unique currency token addresses from theroyaltyClaimDetailsparameter.Key Changes
currencyTokensparameter from the function signatures of:transferToVaultAndSnapshotAndClaimByTokenBatchtransferToVaultAndSnapshotAndClaimBySnapshotBatch_getCurrencyTokenListthat extracts a unique list of currency token addresses from theroyaltyClaimDetailsarray.RoyaltyWorkflowstests to verify that the functions return the correct values.Test
All existing tests pass locally after the changes.