Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new nav params #53

Merged
merged 2 commits into from
Dec 12, 2014
Merged

Conversation

bfalacerda
Copy link
Contributor

No description provided.

@marc-hanheide
Copy link
Member

Is this following some testing vor discussion?

@@ -5,7 +5,7 @@ local_costmap:
rolling_window: true
width: 4.0
height: 4.0
resolution: 0.05
resolution: 0.02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably reset this to 0.05 to keep the parameters the same. If we do, we don't need to test everything twice and we'll be using strands_movebase mostly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. i'll wait for strands-project/strands_movebase#30 to be merged and make all params the same then

@bfalacerda
Copy link
Contributor Author

yes, main discussion is here strands-project/strands_movebase#27 and here strands-project/strands_movebase#30

this one just mirrors strands-project/strands_movebase#30 , because we use the params in this repo when with_chest_camera:=false

@bfalacerda
Copy link
Contributor Author

this should only be merged after we're happy with strands-project/strands_movebase#30 and it is merged

bfalacerda added a commit that referenced this pull request Dec 12, 2014
same params as the new strands_movebase. merging
@bfalacerda bfalacerda merged commit 8443544 into strands-project:hydro-devel Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants