Add logs for participating cosigners #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-rushakoff
approved these changes
Oct 18, 2022
nitronit
added a commit
to nitronit/horcrux
that referenced
this pull request
Oct 19, 2022
Add logs for participating cosigners (strangelove-ventures#111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cosigner is not receiving block sign requests directly from a sentry, there is no log output. This is confusing because it appears as if the cosigner is not participating in signing blocks.
This adds logs for cosigner share signature success/fail to indicate cosigner participation even if it is not receiving block sign requests from a sentry.