Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestValidator #71

Merged
merged 9 commits into from
Apr 12, 2022
Merged

TestValidator #71

merged 9 commits into from
Apr 12, 2022

Conversation

agouin
Copy link
Member

@agouin agouin commented Mar 30, 2022

Functionality improvements:

  • Removes the requirement of an empty home directory to execute config commands. Adds the intended safety of not overwriting the config.yaml without being certain, so the -o/--overwrite flag will be necessary in order to overwrite the existing config when using config init.
  • Shows success message now when config.yaml is initialized
  • cosigner address $BECH32_BASE_PREFIX command will now additionally show the PubKey and valconspub address, which can be used for gentx and tx staking create-validator

Test improvements:

  • Introduces a new struct, TestValidator, to organize test horcrux validators with their signers and sentries, and provide helper methods to simplify test logic.
  • Adds TestChainPureHorcrux to test a chain with only horcrux validators
  • Uses AutoRemove: false on docker containers so that the testing framework can pull logs from container stdin/stdout and log them out in the case of errors before removing the containers.
  • Adds val index to container names

Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is beyond my expertise in the domain as of yet, but I left a few comments on some basic style points.

test/test_setup.go Outdated Show resolved Hide resolved
test/test_validator.go Outdated Show resolved Hide resolved
test/test_validator.go Outdated Show resolved Hide resolved
test/test_signer.go Show resolved Hide resolved
test/test_setup.go Show resolved Hide resolved
test/test_setup.go Outdated Show resolved Hide resolved
test/test_node.go Outdated Show resolved Hide resolved
test/test_node.go Outdated Show resolved Hide resolved
test/test_node.go Show resolved Hide resolved
test/test_node.go Outdated Show resolved Hide resolved
@agouin agouin merged commit 0f7cbf5 into main Apr 12, 2022
@agouin agouin deleted the andrew/horcrux_only_test branch April 12, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants