-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestValidator #71
Merged
Merged
TestValidator #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-rushakoff
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this is beyond my expertise in the domain as of yet, but I left a few comments on some basic style points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality improvements:
config.yaml
without being certain, so the-o
/--overwrite
flag will be necessary in order to overwrite the existing config when usingconfig init
.config.yaml
is initializedcosigner address $BECH32_BASE_PREFIX
command will now additionally show the PubKey and valconspub address, which can be used forgentx
andtx staking create-validator
Test improvements:
TestValidator
, to organize test horcrux validators with their signers and sentries, and provide helper methods to simplify test logic.TestChainPureHorcrux
to test a chain with only horcrux validatorsAutoRemove: false
on docker containers so that the testing framework can pull logs from container stdin/stdout and log them out in the case of errors before removing the containers.