This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use configured ChainClient
key in tx simulation
#171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in tx simulation that would present itself in testing due to how the keystore was managed. Instead of trying to read an arbitrary key to get the PubKey details we retrieve the key information for the calling chain's configured key.
Checklist
Testing
There are no specific test cases in the relayer for Evmos and adding some to the relayer is probably more effort than it's worth since we will be ditching the included integration tests in favor of
ibctest
. Ideally we test EVM based chains inibctest
but that is outside the scope of this work.make test-integration
The tests should all run to completion and pass; before this fix you would see errors like the following