Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Use configured ChainClient key in tx simulation #171

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

jtieri
Copy link
Contributor

@jtieri jtieri commented Jun 7, 2022

Description

This PR fixes a bug in tx simulation that would present itself in testing due to how the keystore was managed. Instead of trying to read an arbitrary key to get the PubKey details we retrieve the key information for the calling chain's configured key.

Checklist

  • I have made sure the upstream branch for this PR is correct
  • I have made sure this PR is ready to merge
  • I have made sure that I have assigned reviewers related to this project

Testing

There are no specific test cases in the relayer for Evmos and adding some to the relayer is probably more effort than it's worth since we will be ditching the included integration tests in favor of ibctest. Ideally we test EVM based chains in ibctest but that is outside the scope of this work.

The tests should all run to completion and pass; before this fix you would see errors like the following

logger.go:130: 2022-06-07T10:52:12.157-0500 INFO    Error building or broadcasting transaction      {"chain_id": "ibc-1", "attempt": 1, "max_attempts": 5, "error": "cannot build signature for simulation, key infos slice is empty"}

@jtieri jtieri marked this pull request as ready for review June 7, 2022 16:17
@jtieri jtieri requested review from joeabbey and mark-rushakoff June 7, 2022 16:17
@jtieri jtieri merged commit 6b6dbf0 into main Jun 7, 2022
@jtieri jtieri deleted the justin/debug-tx-simulation branch June 7, 2022 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants