-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new code block svg file in icons folder #1805
feat: add new code block svg file in icons folder #1805
Conversation
🦋 Changeset detectedLatest commit: 1ca7b1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for the contribution @mukulpadwal 🚀 @lucasboilly please may you take a look at this? 🙏 |
Hey @hanpaine and hey @mukulpadwal, thanks a lot! I's all good, but I don't think it will automatically fix #22058. I think we'll need to specify that that the code block should use the "CodeBlock" icon. It would require a new PR on the CMS side and I guess it's here (line 98), hope it helps! |
Hey @lucasboilly, @hanpaine, @remidej Yes, you’re correct! We should be able to use the Do you think it would be best to close this PR and create a new one that addresses only the design system issue? |
@mukulpadwal thanks for you PR! Just to clarify we need these steps:
I can do 1 to 3 then ping you to open the final PR if that works for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just add a changeset file? (via CLI, see these docs) We need it for our automated releases solution
Hey @remidej, I’ve added the changeset with a detailed description. Let me know if there's anything else you'd like me to update. |
.changeset/violet-impalas-grin.md
Outdated
@@ -0,0 +1,7 @@ | |||
--- | |||
'@strapi/icons': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make it a minor instead?
(I'm not sure it actually matters since the tool is in pre-release mode, but I don't want to take any chances)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remidej changed it from major to minor.
What does it do?
This PR adds a new "Code block" icon to the icon library used in Strapi. The new icon will allow for clearer differentiation between "Code block" and inline "Code" text modifiers.
Why is it needed?
The addition of this icon addresses user feedback indicating confusion between code blocks and inline code. Having a dedicated "Code block" icon will improve the user experience by making it easier to identify the block element, which is distinct from an inline modifier, and aligns with design consistency.
How to test it?
CodeBlock
icon should be visible along with other icons, as shown in the screenshot.CodeBlock
icon matches the intended design and is distinguishable from theCode
icon.Related issue(s)/PR(s)
This PR closes issue #1804 by introducing the "Code block" icon from the Phosphor library and adding it to the design system as part of the icon update process in Strapi 5.