feat : add new svg icons for "xls", "zip" and "csv" #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1be9e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @mukulpadwal, thanks a lot, it's all good from a design point of view! I'll let @remidej approve the code part 🙂 |
remidej
approved these changes
Nov 7, 2024
remidej
added
pr: enhancement
remidej
requested changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds three new icons ("xls," "zip," and "csv") from the Phosphor icon library to enhance file-type representation. The icons are named FileXls, FileZip, and FileCsv to standardize naming.
Why is it needed?
These icons are required for upcoming improvements in the Media Library, allowing users to better identify specific file types.
How to test it?
Storybook Verification : Check the Storybook instance for the icon library. The new icons should be visible along with other icons, as shown in the screenshot.
Related issue(s)/PR(s)
This update addresses part of the requirements outlined in Issue #1813