fix: combobox primitive empty state when autocomplete is none #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HichamELBSI
added
pr: fix
🦋 Changeset detectedLatest commit: f2ad83e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HichamELBSI
force-pushed
the
fix/combobox-primitive-empty-state
branch
from
d09e5fd to
f2ad83e
Compare
simotae14
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR fixes the existing issue that always renders the
No result found(empty state) of the combobox when autocomplete is set to off.Why is it needed?
Avoid rendering the
No result foundat the end of the option list (whenautocomplete = none) which is the case in all Strapi Cloud combobox.How to test it?
Added new unit tests to handle this use case
Related issue(s)/PR(s)
#1803