feat : Add XS size variant to IconButton component #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 680c357 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hanpaine
added
source: design-system
|
Hey @mukulpadwal nice PR! Thanks for submitting, we'll have someone look at it soon 🚀 |
|
@mukulpadwal @simotae14 that's all good 👌 |
markkaylor
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR introduces an XS variant for the
IconButtoncomponent, adding a smaller button size option with 4px padding (0.25rem) around the icon. The changes include:XSsize in theIconButtoncomponent to apply the appropriate padding (padding-block: 0.25rem; - padding-inline: 0.25rem).BUTTON_SIZESconstant to includeXSas a valid option:export const BUTTON_SIZES = ['XS', 'S', 'M', 'L'].Adjusted documentation to reflect the addition of the new
XSsize.Why is it needed?
The addition of the
XSvariant for theIconButtoncomponent addresses the need for smaller buttons in certain parts of the CMS. This will allow for a more elegant UI and simplify the code by eliminating the need to manually define hover states and click areas for each instance. The XS size will provide a more compact and consistent option for icon-only buttons in small UI elements.How to test it?
To test the new XS size, follow these steps:
IconButtoncomponent in Storybook.XSsize variant.Additionally, a video demonstrating the changes has been attached for visual reference, showing the component's behavior with the new XS size.
XS.size.variant.to.IconButton.component.mp4
Related issue(s)/PR(s)
#1820