Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate ERROR_INTERNAL from DbusErrorEnum #1181

Closed
agrover opened this issue Sep 13, 2018 · 1 comment
Closed

Eliminate ERROR_INTERNAL from DbusErrorEnum #1181

agrover opened this issue Sep 13, 2018 · 1 comment
Milestone
Stratis 1.0

Comments

@agrover
Copy link
Contributor

agrover commented Sep 13, 2018

It's just a scarier-sounding version of ERROR.
@agrover agrover added this to the Stratis 1.0 milestone Sep 13, 2018
@agrover agrover mentioned this issue Sep 13, 2018
Merged
agrover pushed a commit to agrover/stratisd that referenced this issue Sep 17, 2018
Remove DbusErrorEnum::INTERNAL_ERROR
2cb6cec 
What is an internal error versus just an error? It sounds scarier, as if
it was unanticipated, perhaps.

Best to just use ERROR.

fixes stratis-storage#1181

Signed-off-by: Andy Grover <[email protected]>
@agrover agrover mentioned this issue Sep 18, 2018
Closed
@agrover
Copy link
Contributor Author

agrover commented Sep 18, 2018

duplicate of #1167

@agrover agrover closed this as completed Sep 18, 2018
agrover pushed a commit to agrover/stratisd that referenced this issue Sep 19, 2018
Remove DbusErrorEnum::INTERNAL_ERROR
c6b0cb5 
What is an internal error versus just an error? It sounds scarier, as if
it was unanticipated, perhaps.

Best to just use ERROR.

fixes stratis-storage#1181

Signed-off-by: Andy Grover <[email protected]>
agrover pushed a commit to agrover/stratisd that referenced this issue Sep 25, 2018
Map Engine errors to DbusErrorEnum::ERROR instead of INTERNAL_ERROR
ecf10d9 
Best to just use ERROR.

fixes stratis-storage#1181

Signed-off-by: Andy Grover <[email protected]>
agrover pushed a commit to agrover/stratisd that referenced this issue Sep 25, 2018
Map Engine errors to DbusErrorEnum::ERROR instead of INTERNAL_ERROR
700e75c 
Best to just use ERROR.

fixes stratis-storage#1181

Signed-off-by: Andy Grover <[email protected]>
agrover pushed a commit to agrover/stratisd that referenced this issue Sep 26, 2018
Map Engine errors to DbusErrorEnum::ERROR instead of INTERNAL_ERROR
b8ff3fc 
Best to just use ERROR.

fixes stratis-storage#1181

Signed-off-by: Andy Grover <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stratis 1.0
Development

No branches or pull requests
1 participant
@agrover