Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop publishing roles to crates.io #1128

Closed
plebhash opened this issue Aug 21, 2024 · 2 comments · Fixed by #1143
Closed

stop publishing roles to crates.io #1128

plebhash opened this issue Aug 21, 2024 · 2 comments · Fixed by #1143
Assignees
Milestone

Comments

@plebhash
Copy link
Collaborator

our release-libs workflow is publishing all roles crates to crates.io

those crates are merely PoCs and not nearly close to production readiness, and won't be for a while

for now, we could simply stop publishing them

- name: Publish crate jd_client
continue-on-error: true
run: |
cd roles/jd-client
cargo publish
- name: Publish crate jd_server
continue-on-error: true
run: |
cd roles/jd-server
cargo publish
- name: Publish crate mining_proxy_sv2
continue-on-error: true
run: |
cd roles/mining-proxy
cargo publish
- name: Publish crate pool_sv2
continue-on-error: true
run: |
cd roles/pool
cargo publish
- name: Publish crate translator_sv2
continue-on-error: true
run: |
cd roles/translator
cargo publish

@plebhash
Copy link
Collaborator Author

tbh I'm leaning towards only publishing the crates under protocols, and not publishing anything else.

@Fi3 should we keep publishing any of these?

  • network_helpers_sv2
  • rpc_sv2
  • bip32-key-derivation
  • error-handling
  • key-utils

@Fi3
Copy link
Collaborator

Fi3 commented Aug 24, 2024

tbh I'm leaning towards only publishing the crates under protocols, and not publishing anything else.

@Fi3 should we keep publishing any of these?

* `network_helpers_sv2`

* `rpc_sv2`

* `bip32-key-derivation`

* `error-handling`

* `key-utils`

yes we should keep publishing them they are fundamental for implementing a role, why do you want stop publishing them?

Maybe we can work for replacing error-handling and having something better or just removing it. All the other one are fundamental. network_helpers_sv2 can be replaced in a impl by https://github.com/demand-open-source/demand-sv2-connection that is the one that I use, but I wouldn't remove network_helpers_sv2 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants