Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop publishing some crates #1143

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

plebhash
Copy link
Collaborator

close #1128

@plebhash plebhash mentioned this pull request Aug 23, 2024
6 tasks
Copy link
Contributor

🐰Bencher

ReportFri, August 23, 2024 at 20:02:38 UTC
ProjectStratum v2 (SRI)
Branchstop-publishing-some-crates
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)43.64 (-2.07%)45.35 (96.22%)
client_sv2_handle_message_mining✅ (view plot)70.48 (-3.45%)80.82 (87.22%)
client_sv2_mining_message_submit_standard✅ (view plot)14.64 (-0.07%)14.69 (99.64%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)270.36 (+2.13%)284.05 (95.18%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)590.73 (-0.47%)626.37 (94.31%)
client_sv2_open_channel✅ (view plot)162.08 (-2.02%)171.47 (94.52%)
client_sv2_open_channel_serialize✅ (view plot)280.81 (-0.74%)293.36 (95.72%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)380.45 (+0.23%)427.28 (89.04%)
client_sv2_setup_connection✅ (view plot)163.36 (-0.37%)174.90 (93.40%)
client_sv2_setup_connection_serialize✅ (view plot)492.16 (+3.82%)505.05 (97.45%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)967.82 (-0.57%)1,044.80 (92.63%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportFri, August 23, 2024 at 20:02:46 UTC
ProjectStratum v2 (SRI)
Branchstop-publishing-some-crates
Testbedsv2

🚨 10 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonL2 Accesses (accesses)🚨 (view plot | view alert)13.00 (+80.82%)11.72 (110.97%)
client_sv2_mining_message_submit_standardL2 Accesses (accesses)🚨 (view plot | view alert)24.00 (+35.41%)23.24 (103.27%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.44%)10,575.99 (100.14%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,404.00 (+0.39%)15,384.23 (100.13%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.51%)8,015.26 (100.15%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,666.00 (+0.42%)11,653.50 (100.11%)
client_sv2_open_channel_serialize_deserializeL2 Accesses (accesses)🚨 (view plot | view alert)86.00 (+16.32%)83.83 (102.58%)
client_sv2_setup_connection_serializeL2 Accesses (accesses)🚨 (view plot | view alert)50.00 (+11.20%)49.89 (100.23%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.28%)14,842.76 (100.08%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,812.00 (+0.27%)21,793.94 (100.08%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,123.00 (+3.30%)2,141.78 (99.12%)✅ (view plot)473.00 (+0.45%)486.03 (97.32%)✅ (view plot)728.00 (-0.56%)754.41 (96.50%)🚨 (view plot | view alert)13.00 (+80.82%)11.72 (110.97%)✅ (view plot)38.00 (+3.33%)38.88 (97.74%)
client_sv2_handle_message_mining✅ (view plot)8,255.00 (+0.67%)8,336.67 (99.02%)✅ (view plot)2,143.00 (+0.69%)2,171.65 (98.68%)✅ (view plot)3,165.00 (+0.60%)3,216.10 (98.41%)✅ (view plot)38.00 (-0.90%)43.40 (87.56%)✅ (view plot)140.00 (+0.78%)141.97 (98.61%)
client_sv2_mining_message_submit_standard✅ (view plot)6,348.00 (+1.09%)6,395.63 (99.26%)✅ (view plot)1,756.00 (+0.34%)1,763.58 (99.57%)✅ (view plot)2,553.00 (-0.04%)2,575.29 (99.13%)🚨 (view plot | view alert)24.00 (+35.41%)23.24 (103.27%)✅ (view plot)105.00 (+1.05%)106.97 (98.16%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,847.00 (+0.43%)15,034.41 (98.75%)✅ (view plot)4,700.00 (+0.13%)4,707.58 (99.84%)✅ (view plot)6,757.00 (+0.03%)6,774.92 (99.74%)✅ (view plot)50.00 (+5.80%)51.72 (96.68%)✅ (view plot)224.00 (+0.60%)229.92 (97.42%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,629.00 (+0.51%)27,852.93 (99.20%)🚨 (view plot | view alert)10,591.00 (+0.44%)10,575.99 (100.14%)🚨 (view plot | view alert)15,404.00 (+0.39%)15,384.23 (100.13%)✅ (view plot)86.00 (+2.70%)89.12 (96.50%)✅ (view plot)337.00 (+0.57%)345.25 (97.61%)
client_sv2_open_channel✅ (view plot)4,361.00 (-2.80%)4,620.23 (94.39%)✅ (view plot)1,461.00 (+0.05%)1,473.99 (99.12%)✅ (view plot)2,156.00 (+0.15%)2,172.39 (99.25%)✅ (view plot)14.00 (+15.50%)15.39 (90.98%)✅ (view plot)61.00 (-6.08%)68.58 (88.95%)
client_sv2_open_channel_serialize✅ (view plot)14,084.00 (-0.92%)14,453.87 (97.44%)✅ (view plot)5,064.00 (+0.01%)5,076.99 (99.74%)✅ (view plot)7,324.00 (+0.08%)7,339.06 (99.79%)✅ (view plot)36.00 (-2.88%)41.29 (87.19%)✅ (view plot)188.00 (-1.95%)198.64 (94.64%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,701.00 (+0.23%)23,020.57 (98.61%)🚨 (view plot | view alert)8,027.00 (+0.51%)8,015.26 (100.15%)🚨 (view plot | view alert)11,666.00 (+0.42%)11,653.50 (100.11%)🚨 (view plot | view alert)86.00 (+16.32%)83.83 (102.58%)✅ (view plot)303.00 (-0.54%)314.64 (96.30%)
client_sv2_setup_connection✅ (view plot)4,689.00 (-0.22%)4,765.42 (98.40%)✅ (view plot)1,502.00 (+0.05%)1,514.99 (99.14%)✅ (view plot)2,274.00 (-0.12%)2,298.85 (98.92%)✅ (view plot)14.00 (+50.65%)14.20 (98.60%)✅ (view plot)67.00 (-1.32%)69.63 (96.23%)
client_sv2_setup_connection_serialize✅ (view plot)16,184.00 (-0.53%)16,479.92 (98.20%)✅ (view plot)5,963.00 (+0.01%)5,975.99 (99.78%)✅ (view plot)8,654.00 (-0.01%)8,676.42 (99.74%)🚨 (view plot | view alert)50.00 (+11.20%)49.89 (100.23%)✅ (view plot)208.00 (-1.49%)217.14 (95.79%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,592.00 (+0.14%)35,750.17 (99.56%)🚨 (view plot | view alert)14,855.00 (+0.28%)14,842.76 (100.08%)🚨 (view plot | view alert)21,812.00 (+0.27%)21,793.94 (100.08%)✅ (view plot)103.00 (+3.23%)112.33 (91.69%)✅ (view plot)379.00 (-0.19%)384.29 (98.62%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportFri, August 23, 2024 at 20:03:03 UTC
ProjectStratum v2 (SRI)
Branchstop-publishing-some-crates
Testbedsv1

🚨 4 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_authorizeRAM Accesses (accesses)🚨 (view plot | view alert)299.00 (+1.40%)298.02 (100.33%)
serialize_deserialize_handle_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)390.00 (+1.09%)389.20 (100.21%)
serialize_deserialize_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)324.00 (+1.66%)322.43 (100.49%)
serialize_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)161.00 (+3.55%)160.85 (100.09%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,541.00 (+1.31%)8,744.22 (97.68%)✅ (view plot)3,772.00 (+0.87%)3,864.38 (97.61%)✅ (view plot)5,296.00 (+0.97%)5,414.16 (97.82%)✅ (view plot)5.00 (-35.31%)10.59 (47.20%)✅ (view plot)92.00 (+2.32%)94.21 (97.65%)
get_submit✅ (view plot)95,718.00 (+0.17%)96,168.93 (99.53%)✅ (view plot)59,522.00 (+0.09%)59,779.04 (99.57%)✅ (view plot)85,498.00 (+0.10%)85,838.35 (99.60%)✅ (view plot)49.00 (-10.61%)62.64 (78.22%)✅ (view plot)285.00 (+1.09%)288.77 (98.69%)
get_subscribe✅ (view plot)8,102.00 (+1.60%)8,298.48 (97.63%)✅ (view plot)2,848.00 (+0.73%)2,948.57 (96.59%)✅ (view plot)3,982.00 (+0.78%)4,111.38 (96.85%)✅ (view plot)12.00 (-24.68%)20.29 (59.15%)✅ (view plot)116.00 (+2.95%)117.47 (98.75%)
serialize_authorize✅ (view plot)12,392.00 (+1.51%)12,539.00 (98.83%)✅ (view plot)5,343.00 (+0.61%)5,435.38 (98.30%)✅ (view plot)7,457.00 (+0.67%)7,577.13 (98.41%)✅ (view plot)7.00 (-33.60%)13.74 (50.95%)✅ (view plot)140.00 (+3.21%)140.93 (99.34%)
serialize_deserialize_authorize✅ (view plot)24,670.00 (+0.81%)24,733.17 (99.74%)✅ (view plot)9,950.00 (+0.49%)10,036.13 (99.14%)✅ (view plot)14,050.00 (+0.57%)14,165.86 (99.18%)✅ (view plot)31.00 (-14.81%)41.90 (73.98%)🚨 (view plot | view alert)299.00 (+1.40%)298.02 (100.33%)
serialize_deserialize_handle_authorize✅ (view plot)30,308.00 (+0.56%)30,378.75 (99.77%)✅ (view plot)12,127.00 (+0.27%)12,219.38 (99.24%)✅ (view plot)17,163.00 (+0.27%)17,291.41 (99.26%)✅ (view plot)60.00 (+2.08%)64.61 (92.87%)✅ (view plot)367.00 (+0.91%)367.32 (99.91%)
serialize_deserialize_handle_submit✅ (view plot)126,609.00 (+0.16%)127,077.87 (99.63%)✅ (view plot)73,307.00 (+0.08%)73,624.10 (99.57%)✅ (view plot)105,094.00 (+0.10%)105,519.48 (99.60%)✅ (view plot)110.00 (-8.00%)132.08 (83.28%)✅ (view plot)599.00 (+0.72%)600.76 (99.71%)
serialize_deserialize_handle_subscribe✅ (view plot)27,622.00 (+0.62%)27,652.75 (99.89%)✅ (view plot)9,650.00 (+0.21%)9,750.57 (98.97%)✅ (view plot)13,647.00 (+0.20%)13,786.37 (98.99%)✅ (view plot)65.00 (-1.36%)73.50 (88.43%)🚨 (view plot | view alert)390.00 (+1.09%)389.20 (100.21%)
serialize_deserialize_submit✅ (view plot)115,367.00 (+0.24%)115,690.75 (99.72%)✅ (view plot)68,167.00 (+0.15%)68,409.27 (99.65%)✅ (view plot)97,842.00 (+0.18%)98,165.26 (99.67%)✅ (view plot)61.00 (-11.68%)76.22 (80.03%)✅ (view plot)492.00 (+0.81%)493.65 (99.67%)
serialize_deserialize_subscribe✅ (view plot)23,088.00 (+0.92%)23,148.21 (99.74%)✅ (view plot)8,209.00 (+0.30%)8,306.38 (98.83%)✅ (view plot)11,563.00 (+0.31%)11,694.50 (98.88%)✅ (view plot)37.00 (-5.95%)43.97 (84.14%)🚨 (view plot | view alert)324.00 (+1.66%)322.43 (100.49%)
serialize_submit✅ (view plot)100,125.00 (+0.23%)100,506.59 (99.62%)✅ (view plot)61,566.00 (+0.08%)61,828.09 (99.58%)✅ (view plot)88,345.00 (+0.10%)88,691.62 (99.61%)✅ (view plot)46.00 (-16.85%)63.23 (72.76%)✅ (view plot)330.00 (+1.63%)330.99 (99.70%)
serialize_subscribe✅ (view plot)11,541.00 (+1.85%)11,652.06 (99.05%)✅ (view plot)4,195.00 (+0.49%)4,295.57 (97.66%)✅ (view plot)5,836.00 (+0.47%)5,970.19 (97.75%)✅ (view plot)14.00 (-13.60%)19.32 (72.48%)🚨 (view plot | view alert)161.00 (+3.55%)160.85 (100.09%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportFri, August 23, 2024 at 20:03:05 UTC
ProjectStratum v2 (SRI)
Branch1143/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,493.20 (-6.35%)7,353.54 (88.30%)
client-submit-serialize-deserialize✅ (view plot)7,306.20 (-6.98%)8,360.36 (87.39%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,024.60 (-4.73%)8,851.45 (90.66%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)899.23 (+0.10%)926.20 (97.09%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)703.68 (+0.94%)717.86 (98.02%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)251.61 (+1.40%)255.31 (98.55%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.30 (+0.10%)162.37 (96.88%)
client-sv1-get-submit✅ (view plot)6,342.60 (-5.35%)7,143.49 (88.79%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)278.26 (-0.10%)291.03 (95.61%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)769.04 (+2.86%)777.23 (98.95%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)605.82 (-1.35%)637.31 (95.06%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)204.55 (-1.04%)219.84 (93.05%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to the change, why do we have continue-on-error ? if one crate does not update while other crates depend on it, and those update, this can break things. is it possible to publish all crates in a single atomic command?

@plebhash
Copy link
Collaborator Author

unrelated to the change, why do we have continue-on-error ? if one crate does not update while other crates depend on it, and those update, this can break things. is it possible to publish all crates in a single atomic command?

migrated this discussion to #1142

@plebhash plebhash merged commit 8da5642 into stratum-mining:dev Aug 28, 2024
33 checks passed
@plebhash plebhash deleted the stop-publishing-some-crates branch August 28, 2024 16:53
@plebhash plebhash restored the stop-publishing-some-crates branch August 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop publishing roles to crates.io
3 participants