global release docs #1154
Merged
global release docs #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Wed, September 4, 2024 at 13:00:42 UTC |
| Project | Stratum V2 (SRI) |
| Branch | 1154/merge |
| Testbed | sv1 |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 675.26 (+8.58%) | 588.01 (87.08%) | 655.76 (102.97%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| client-submit-serialize | ✅ (view plot) | 7,069.70 (+2.89%) | 6,424.09 (90.87%) | 7,318.21 (96.60%) |
| client-submit-serialize-deserialize | ✅ (view plot) | 8,173.70 (+4.24%) | 7,309.11 (89.42%) | 8,373.86 (97.61%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8,621.10 (+2.54%) | 7,957.90 (92.31%) | 8,857.90 (97.33%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 921.50 (+1.48%) | 870.83 (94.50%) | 945.23 (97.49%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 719.84 (+1.77%) | 677.00 (94.05%) | 737.60 (97.59%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 253.71 (+1.89%) | 242.23 (95.48%) | 255.75 (99.20%) |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 158.20 (+0.52%) | 152.59 (96.46%) | 162.16 (97.56%) |
| client-sv1-get-submit | ✅ (view plot) | 6,850.60 (+2.98%) | 6,213.47 (90.70%) | 7,091.77 (96.60%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 279.53 (+0.91%) | 262.86 (94.04%) | 291.18 (96.00%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 786.23 (+3.51%) | 720.57 (91.65%) | 798.64 (98.45%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 🚨 (view plot | view alert) | 675.26 (+8.58%) | 588.01 (87.08%) | 655.76 (102.97%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 209.96 (+1.08%) | 195.32 (93.03%) | 220.13 (95.38%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Wed, September 4, 2024 at 13:00:50 UTC |
| Project | Stratum V2 (SRI) |
| Branch | global-release-docs |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Lower Boundary estimated cycles | (%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Lower Boundary instructions | (%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Lower Boundary accesses | (%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Lower Boundary accesses | (%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Lower Boundary accesses | (%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8,545.00 (+1.20%) | 8,202.82 (96.00%) | 8,685.24 (98.39%) | ✅ (view plot) | 3,772.00 (+0.63%) | 3,654.27 (96.88%) | 3,842.52 (98.16%) | ✅ (view plot) | 5,295.00 (+0.71%) | 5,128.12 (96.85%) | 5,387.05 (98.29%) | ✅ (view plot) | 6.00 (-17.68%) | 4.59 (76.54%) | 9.98 (60.09%) | ✅ (view plot) | 92.00 (+2.22%) | 86.52 (94.04%) | 93.48 (98.41%) |
| get_submit | ✅ (view plot) | 95,446.00 (-0.05%) | 94,997.11 (99.53%) | 95,992.76 (99.43%) | ✅ (view plot) | 59,522.00 (+0.08%) | 59,244.01 (99.53%) | 59,703.52 (99.70%) | ✅ (view plot) | 85,506.00 (+0.10%) | 85,095.60 (99.52%) | 85,744.18 (99.72%) | ✅ (view plot) | 49.00 (-1.06%) | 35.40 (72.24%) | 63.65 (76.99%) | ✅ (view plot) | 277.00 (-1.35%) | 274.03 (98.93%) | 287.53 (96.34%) |
| get_subscribe | ✅ (view plot) | 8,064.00 (+0.77%) | 7,758.07 (96.21%) | 8,246.90 (97.78%) | ✅ (view plot) | 2,848.00 (+0.44%) | 2,746.05 (96.42%) | 2,925.26 (97.36%) | ✅ (view plot) | 3,984.00 (+0.51%) | 3,844.04 (96.49%) | 4,083.91 (97.55%) | ✅ (view plot) | 11.00 (-18.05%) | 6.81 (61.93%) | 20.03 (54.91%) | ✅ (view plot) | 115.00 (+1.35%) | 109.48 (95.20%) | 117.46 (97.90%) |
| serialize_authorize | ✅ (view plot) | 12,328.00 (+0.67%) | 11,984.09 (97.21%) | 12,507.91 (98.56%) | ✅ (view plot) | 5,343.00 (+0.44%) | 5,225.27 (97.80%) | 5,413.52 (98.70%) | ✅ (view plot) | 7,458.00 (+0.51%) | 7,290.15 (97.75%) | 7,549.51 (98.79%) | ✅ (view plot) | 8.00 (-15.91%) | 5.99 (74.83%) | 13.04 (61.35%) | ✅ (view plot) | 138.00 (+1.08%) | 132.04 (95.68%) | 141.02 (97.86%) |
| serialize_deserialize_authorize | ✅ (view plot) | 24,927.00 (+1.36%) | 24,232.37 (97.21%) | 24,954.39 (99.89%) | ✅ (view plot) | 9,920.00 (+0.20%) | 9,791.02 (98.70%) | 10,008.70 (99.11%) | ✅ (view plot) | 14,017.00 (+0.32%) | 13,812.20 (98.54%) | 14,132.93 (99.18%) | ✅ (view plot) | 33.00 (-7.57%) | 30.13 (91.31%) | 41.27 (79.96%) | ✅ (view plot) | 307.00 (+2.90%) | 289.30 (94.23%) | 307.41 (99.87%) |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30,469.00 (+0.76%) | 29,943.45 (98.28%) | 30,534.88 (99.78%) | ✅ (view plot) | 12,097.00 (+0.04%) | 11,996.52 (99.17%) | 12,188.11 (99.25%) | ✅ (view plot) | 17,139.00 (+0.11%) | 16,985.39 (99.10%) | 17,253.74 (99.33%) | ✅ (view plot) | 55.00 (-3.72%) | 50.39 (91.62%) | 63.86 (86.12%) | ✅ (view plot) | 373.00 (+1.72%) | 358.75 (96.18%) | 374.61 (99.57%) |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126,493.00 (+0.03%) | 125,951.11 (99.57%) | 126,952.08 (99.64%) | ✅ (view plot) | 73,363.00 (+0.12%) | 72,994.34 (99.50%) | 73,556.42 (99.74%) | ✅ (view plot) | 105,198.00 (+0.15%) | 104,634.91 (99.46%) | 105,448.73 (99.76%) | ✅ (view plot) | 108.00 (-3.76%) | 92.56 (85.70%) | 131.89 (81.88%) | ✅ (view plot) | 593.00 (-0.45%) | 589.78 (99.46%) | 601.58 (98.57%) |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 28,017.00 (+1.30%) | 27,119.05 (96.79%) | 28,197.22 (99.36%) | ✅ (view plot) | 9,666.00 (+0.23%) | 9,550.36 (98.80%) | 9,736.78 (99.27%) | ✅ (view plot) | 13,677.00 (+0.26%) | 13,511.34 (98.79%) | 13,770.78 (99.32%) | ✅ (view plot) | 61.00 (-4.90%) | 56.06 (91.91%) | 72.22 (84.46%) | ✅ (view plot) | 401.00 (+2.47%) | 377.15 (94.05%) | 405.50 (98.89%) |
| serialize_deserialize_submit | ✅ (view plot) | 115,445.00 (+0.23%) | 114,673.84 (99.33%) | 115,682.94 (99.79%) | ✅ (view plot) | 68,223.00 (+0.19%) | 67,815.23 (99.40%) | 68,365.36 (99.79%) | ✅ (view plot) | 97,935.00 (+0.23%) | 97,296.97 (99.35%) | 98,123.59 (99.81%) | ✅ (view plot) | 65.00 (-0.21%) | 54.22 (83.42%) | 76.05 (85.47%) | ✅ (view plot) | 491.00 (+0.25%) | 484.18 (98.61%) | 495.39 (99.11%) |
| serialize_deserialize_subscribe | ✅ (view plot) | 23,469.00 (+1.65%) | 22,541.48 (96.05%) | 23,632.63 (99.31%) | ✅ (view plot) | 8,225.00 (+0.32%) | 8,104.06 (98.53%) | 8,292.75 (99.18%) | ✅ (view plot) | 11,589.00 (+0.35%) | 11,418.16 (98.53%) | 11,678.56 (99.23%) | ✅ (view plot) | 38.00 (-0.59%) | 33.63 (88.49%) | 42.82 (88.74%) | ✅ (view plot) | 334.00 (+3.02%) | 310.41 (92.94%) | 338.03 (98.81%) |
| serialize_submit | ✅ (view plot) | 99,839.00 (-0.04%) | 99,415.48 (99.58%) | 100,350.66 (99.49%) | ✅ (view plot) | 61,566.00 (+0.08%) | 61,285.13 (99.54%) | 61,750.94 (99.70%) | ✅ (view plot) | 88,349.00 (+0.10%) | 87,934.16 (99.53%) | 88,593.97 (99.72%) | ✅ (view plot) | 51.00 (+0.48%) | 38.53 (75.56%) | 62.98 (80.98%) | ✅ (view plot) | 321.00 (-1.15%) | 318.49 (99.22%) | 330.95 (96.99%) |
| serialize_subscribe | ✅ (view plot) | 11,405.00 (+0.26%) | 11,115.92 (97.47%) | 11,635.95 (98.02%) | ✅ (view plot) | 4,195.00 (+0.30%) | 4,093.05 (97.57%) | 4,272.26 (98.19%) | ✅ (view plot) | 5,840.00 (+0.33%) | 5,700.92 (97.62%) | 5,940.78 (98.30%) | ✅ (view plot) | 14.00 (-2.45%) | 9.44 (67.44%) | 19.26 (72.69%) | ✅ (view plot) | 157.00 (+0.21%) | 151.57 (96.54%) | 161.77 (97.05%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Wed, September 4, 2024 at 13:00:48 UTC |
| Project | Stratum V2 (SRI) |
| Branch | global-release-docs |
| Testbed | sv2 |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| client_sv2_open_channel | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 173.05 (+4.22%) | 159.92 (92.41%) | 172.18 (100.51%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.24 (-0.86%) | 43.62 (98.59%) | 45.64 (96.95%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 74.51 (+0.55%) | 65.15 (87.44%) | 83.06 (89.71%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.70 (+0.25%) | 14.60 (99.32%) | 14.73 (99.81%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 261.82 (-1.62%) | 248.05 (94.74%) | 284.18 (92.13%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 585.29 (-1.41%) | 561.42 (95.92%) | 625.95 (93.50%) |
| client_sv2_open_channel | 🚨 (view plot | view alert) | 173.05 (+4.22%) | 159.92 (92.41%) | 172.18 (100.51%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 270.52 (-3.53%) | 265.84 (98.27%) | 294.99 (91.70%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 378.32 (+0.23%) | 332.46 (87.88%) | 422.46 (89.55%) |
| client_sv2_setup_connection | ✅ (view plot) | 155.22 (-4.76%) | 151.31 (97.48%) | 174.66 (88.87%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 446.62 (-4.64%) | 418.60 (93.73%) | 518.10 (86.20%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 951.00 (-3.21%) | 897.11 (94.33%) | 1,068.05 (89.04%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Wed, September 4, 2024 at 13:00:46 UTC |
| Project | Stratum V2 (SRI) |
| Branch | global-release-docs |
| Testbed | sv2 |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| client_sv2_handle_message_mining | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 29.00 (-20.04%) | 29.39 (101.33%) | 43.15 (67.21%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Lower Boundary estimated cycles | (%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Lower Boundary instructions | (%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Lower Boundary accesses | (%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Lower Boundary accesses | (%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Lower Boundary accesses | (%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2,087.00 (+0.76%) | 1,987.58 (95.24%) | 2,154.83 (96.85%) | ✅ (view plot) | 473.00 (+0.32%) | 459.59 (97.17%) | 483.41 (97.85%) | ✅ (view plot) | 737.00 (+0.50%) | 715.32 (97.06%) | 751.35 (98.09%) | ✅ (view plot) | 4.00 (-34.55%) | 0.38 (9.50%) | 11.84 (33.78%) | ✅ (view plot) | 38.00 (+1.74%) | 35.03 (92.19%) | 39.67 (95.78%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 8,142.00 (-0.67%) | 8,088.43 (99.34%) | 8,306.11 (98.02%) | ✅ (view plot) | 2,137.00 (+0.20%) | 2,099.71 (98.26%) | 2,165.88 (98.67%) | ✅ (view plot) | 3,167.00 (+0.42%) | 3,100.09 (97.89%) | 3,207.60 (98.73%) | 🚨 (view plot | view alert) | 29.00 (-20.04%) | 29.39 (101.33%) | 43.15 (67.21%) | ✅ (view plot) | 138.00 (-0.66%) | 136.50 (98.91%) | 141.34 (97.64%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6,239.00 (-0.60%) | 6,181.35 (99.08%) | 6,372.37 (97.91%) | ✅ (view plot) | 1,750.00 (-0.00%) | 1,738.76 (99.36%) | 1,761.39 (99.35%) | ✅ (view plot) | 2,554.00 (+0.03%) | 2,535.47 (99.27%) | 2,571.21 (99.33%) | ✅ (view plot) | 16.00 (-7.10%) | 12.08 (75.50%) | 22.36 (71.54%) | ✅ (view plot) | 103.00 (-0.89%) | 101.34 (98.39%) | 106.51 (96.70%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14,662.00 (-0.63%) | 14,544.04 (99.20%) | 14,965.72 (97.97%) | ✅ (view plot) | 4,694.00 (-0.00%) | 4,682.76 (99.76%) | 4,705.39 (99.76%) | ✅ (view plot) | 6,762.00 (+0.08%) | 6,739.60 (99.67%) | 6,773.78 (99.83%) | ✅ (view plot) | 40.00 (-10.45%) | 37.32 (93.29%) | 52.02 (76.90%) | ✅ (view plot) | 220.00 (-0.96%) | 216.28 (98.31%) | 228.00 (96.49%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27,520.00 (+0.05%) | 27,234.79 (98.96%) | 27,780.33 (99.06%) | ✅ (view plot) | 10,585.00 (+0.21%) | 10,515.30 (99.34%) | 10,611.15 (99.75%) | ✅ (view plot) | 15,405.00 (+0.22%) | 15,300.85 (99.32%) | 15,440.74 (99.77%) | ✅ (view plot) | 78.00 (-4.53%) | 75.54 (96.85%) | 87.87 (88.77%) | ✅ (view plot) | 335.00 (-0.03%) | 327.48 (97.75%) | 342.71 (97.75%) |
| client_sv2_open_channel | ✅ (view plot) | 4,371.00 (-1.41%) | 4,271.61 (97.73%) | 4,595.09 (95.12%) | ✅ (view plot) | 1,461.00 (+0.05%) | 1,449.36 (99.20%) | 1,471.12 (99.31%) | ✅ (view plot) | 2,161.00 (+0.24%) | 2,138.64 (98.97%) | 2,173.07 (99.44%) | ✅ (view plot) | 8.00 (-22.72%) | 5.13 (64.16%) | 15.57 (51.38%) | ✅ (view plot) | 62.00 (-2.50%) | 59.27 (95.60%) | 67.91 (91.30%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 13,962.00 (-1.18%) | 13,854.38 (99.23%) | 14,401.77 (96.95%) | ✅ (view plot) | 5,064.00 (+0.01%) | 5,052.36 (99.77%) | 5,074.12 (99.80%) | ✅ (view plot) | 7,332.00 (+0.13%) | 7,302.88 (99.60%) | 7,341.88 (99.87%) | ✅ (view plot) | 31.00 (-11.33%) | 28.85 (93.06%) | 41.08 (75.47%) | ✅ (view plot) | 185.00 (-2.35%) | 181.88 (98.31%) | 197.03 (93.90%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22,619.00 (-0.10%) | 22,363.84 (98.87%) | 22,917.51 (98.70%) | ✅ (view plot) | 8,027.00 (+0.28%) | 7,957.50 (99.13%) | 8,051.28 (99.70%) | ✅ (view plot) | 11,679.00 (+0.29%) | 11,575.17 (99.11%) | 11,714.24 (99.70%) | ✅ (view plot) | 74.00 (+0.64%) | 65.69 (88.78%) | 81.36 (90.95%) | ✅ (view plot) | 302.00 (-0.55%) | 295.80 (97.95%) | 311.53 (96.94%) |
| client_sv2_setup_connection | ✅ (view plot) | 4,669.00 (-0.39%) | 4,622.41 (99.00%) | 4,752.59 (98.24%) | ✅ (view plot) | 1,502.00 (+0.05%) | 1,490.36 (99.23%) | 1,512.12 (99.33%) | ✅ (view plot) | 2,279.00 (+0.09%) | 2,259.60 (99.15%) | 2,294.20 (99.34%) | ✅ (view plot) | 9.00 (-3.86%) | 4.90 (54.46%) | 13.82 (65.12%) | ✅ (view plot) | 67.00 (-0.80%) | 65.69 (98.05%) | 69.38 (96.57%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 16,140.00 (-0.43%) | 15,998.86 (99.13%) | 16,420.80 (98.29%) | ✅ (view plot) | 5,963.00 (+0.01%) | 5,951.36 (99.80%) | 5,973.12 (99.83%) | ✅ (view plot) | 8,665.00 (+0.07%) | 8,638.92 (99.70%) | 8,679.55 (99.83%) | ✅ (view plot) | 39.00 (-6.71%) | 32.63 (83.66%) | 50.98 (76.49%) | ✅ (view plot) | 208.00 (-0.84%) | 204.16 (98.15%) | 215.36 (96.58%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35,578.00 (+0.09%) | 35,385.90 (99.46%) | 35,709.66 (99.63%) | ✅ (view plot) | 14,855.00 (+0.16%) | 14,783.99 (99.52%) | 14,879.77 (99.83%) | ✅ (view plot) | 21,823.00 (+0.17%) | 21,706.83 (99.47%) | 21,865.12 (99.81%) | ✅ (view plot) | 91.00 (-3.97%) | 79.73 (87.62%) | 109.79 (82.89%) | ✅ (view plot) | 380.00 (+0.09%) | 375.90 (98.92%) | 383.41 (99.11%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
GitGab19
approved these changes
Sep 4, 2024
jbesraa
reviewed
Sep 4, 2024
plebhash
force-pushed
the
global-release-docs
branch
from
7ad09a2 to
5c341d6
Compare
jbesraa
approved these changes
Sep 4, 2024
pavlenex
force-pushed
the
global-release-docs
branch
from
5c341d6 to
03c131b
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formalizing @GitGab19 's proposal: #1141 (comment)