Docs for Template Distribution Messages #1257

jbesraa · 2024-11-17T16:19:32Z

resolves #1206

codecov · 2024-11-17T16:22:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.63%. Comparing base (8c8a440) to head (7f388ce).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
+ Coverage   19.30%   19.63%   +0.33%     
==========================================
  Files         164      153      -11     
  Lines       10849    10029     -820     
==========================================
- Hits         2094     1969     -125     
+ Misses       8755     8060     -695

Flag	Coverage Δ
binary_codec_sv2-coverage	`0.00% <ø> (ø)`
binary_serde_sv2-coverage	`3.65% <ø> (ø)`
binary_sv2-coverage	`5.46% <ø> (ø)`
bip32_derivation-coverage	`0.00% <ø> (ø)`
buffer_sv2-coverage	`25.02% <ø> (ø)`
codec_sv2-coverage	`0.01% <ø> (ø)`
common_messages_sv2-coverage	`0.13% <ø> (ø)`
const_sv2-coverage	`0.00% <ø> (ø)`
error_handling-coverage	`0.00% <ø> (ø)`
framing_sv2-coverage	`0.29% <ø> (ø)`
jd_client-coverage	`0.00% <ø> (ø)`
jd_server-coverage	`7.79% <ø> (ø)`
job_declaration_sv2-coverage	`0.00% <ø> (ø)`
key-utils-coverage	`2.39% <ø> (ø)`
mining-coverage	`2.51% <ø> (ø)`
mining_device-coverage	`0.00% <ø> (ø)`
mining_proxy_sv2-coverage	`0.70% <ø> (ø)`
noise_sv2-coverage	`4.35% <ø> (ø)`
pool_sv2-coverage	`1.38% <ø> (ø)`
protocols	`24.72% <ø> (ø)`
roles	`3.64% <ø> (-2.92%)`	⬇️
roles_logic_sv2-coverage	`8.06% <ø> (ø)`
sv2_ffi-coverage	`0.00% <ø> (ø)`
template_distribution_sv2-coverage	`0.00% <ø> (ø)`
translator_sv2-coverage	`?`
utils	`25.13% <ø> (ø)`
v1-coverage	`2.47% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-11-17T16:23:40Z

Bencher Report

Branch	2024-11-08-template-distribution-msgs-docs
Testbed	sv2

🚨 4 Alerts

Benchmark	Measure Units	View	Benchmark Result (Result Δ%)	Upper Boundary (Limit %)
client_sv2_handle_message_mining	Estimated Cycles estimated cycles	📈 plot 🚨 alert (🔔) 🚷 threshold	8,314.00 (+1.32%)	8,306.49 (100.09%)
client_sv2_handle_message_mining	RAM Accesses accesses	📈 plot 🚨 alert (🔔) 🚷 threshold	142.00 (+2.10%)	141.73 (100.19%)
client_sv2_mining_message_submit_standard_serialize_deserialize	L2 Accesses accesses	📈 plot 🚨 alert (🔔) 🚷 threshold	94.00 (+15.03%)	92.03 (102.14%)
client_sv2_open_channel_serialize_deserialize	L2 Accesses accesses	📈 plot 🚨 alert (🔔) 🚷 threshold	87.00 (+16.62%)	85.93 (101.24%)

Click to view all benchmark results

Benchmark	Estimated Cycles	Benchmark Result estimated cycles (Result Δ%)	Upper Boundary estimated cycles (Limit %)	Instructions	Benchmark Result instructions (Result Δ%)	Upper Boundary instructions (Limit %)	L1 Accesses	Benchmark Result accesses (Result Δ%)	Upper Boundary accesses (Limit %)	L2 Accesses	Benchmark Result accesses (Result Δ%)	Upper Boundary accesses (Limit %)	RAM Accesses	Benchmark Result accesses (Result Δ%)	Upper Boundary accesses (Limit %)
client_sv2_handle_message_common	📈 view plot 🚷 view threshold	2,121.00 (+1.07%)	2,215.99 (95.71%)	📈 view plot 🚷 view threshold	473.00 (-0.06%)	488.67 (96.79%)	📈 view plot 🚷 view threshold	736.00 (+0.01%)	757.47 (97.17%)	📈 view plot 🚷 view threshold	4.00 (-23.35%)	13.30 (30.07%)	📈 view plot 🚷 view threshold	39.00 (+2.13%)	41.41 (94.18%)
client_sv2_handle_message_mining	📈 view plot 🚨 view alert (🔔) 🚷 view threshold	8,314.00 (+1.32%)	8,306.49 (100.09%)	📈 view plot 🚷 view threshold	2,137.00 (-0.03%)	2,143.08 (99.72%)	📈 view plot 🚷 view threshold	3,154.00 (-0.21%)	3,170.87 (99.47%)	📈 view plot 🚷 view threshold	38.00 (+7.42%)	41.29 (92.03%)	📈 view plot 🚨 view alert (🔔) 🚷 view threshold	142.00 (+2.10%)	141.73 (100.19%)
client_sv2_mining_message_submit_standard	📈 view plot 🚷 view threshold	6,353.00 (+1.09%)	6,411.52 (99.09%)	📈 view plot 🚷 view threshold	1,750.00 (-0.05%)	1,767.03 (99.04%)	📈 view plot 🚷 view threshold	2,548.00 (-0.21%)	2,575.89 (98.92%)	📈 view plot 🚷 view threshold	19.00 (+12.38%)	24.22 (78.46%)	📈 view plot 🚷 view threshold	106.00 (+1.75%)	107.72 (98.41%)
client_sv2_mining_message_submit_standard_serialize	📈 view plot 🚷 view threshold	14,778.00 (+0.35%)	14,943.51 (98.89%)	📈 view plot 🚷 view threshold	4,694.00 (-0.02%)	4,711.03 (99.64%)	📈 view plot 🚷 view threshold	6,748.00 (-0.15%)	6,783.18 (99.48%)	📈 view plot 🚷 view threshold	52.00 (+19.13%)	54.79 (94.91%)	📈 view plot 🚷 view threshold	222.00 (+0.27%)	227.10 (97.75%)
client_sv2_mining_message_submit_standard_serialize_deserialize	📈 view plot 🚷 view threshold	27,766.00 (+0.80%)	27,866.13 (99.64%)	📈 view plot 🚷 view threshold	10,645.00 (+0.54%)	10,664.61 (99.82%)	📈 view plot 🚷 view threshold	15,501.00 (+0.60%)	15,533.65 (99.79%)	📈 view plot 🚨 view alert (🔔) 🚷 view threshold	94.00 (+15.03%)	92.03 (102.14%)	📈 view plot 🚷 view threshold	337.00 (+0.58%)	341.62 (98.65%)
client_sv2_open_channel	📈 view plot 🚷 view threshold	4,451.00 (+1.35%)	4,582.86 (97.12%)	📈 view plot 🚷 view threshold	1,461.00 (-0.02%)	1,476.67 (98.94%)	📈 view plot 🚷 view threshold	2,156.00 (-0.19%)	2,184.15 (98.71%)	📈 view plot 🚷 view threshold	11.00 (+26.96%)	16.40 (67.09%)	📈 view plot 🚷 view threshold	64.00 (+2.36%)	67.73 (94.50%)
client_sv2_open_channel_serialize	📈 view plot 🚷 view threshold	14,040.00 (+0.01%)	14,338.22 (97.92%)	📈 view plot 🚷 view threshold	5,064.00 (-0.01%)	5,079.67 (99.69%)	📈 view plot 🚷 view threshold	7,320.00 (-0.09%)	7,351.58 (99.57%)	📈 view plot 🚷 view threshold	42.00 (+19.20%)	44.35 (94.69%)	📈 view plot 🚷 view threshold	186.00 (-0.41%)	195.41 (95.18%)
client_sv2_open_channel_serialize_deserialize	📈 view plot 🚷 view threshold	22,798.00 (+0.58%)	22,928.30 (99.43%)	📈 view plot 🚷 view threshold	8,040.00 (+0.20%)	8,070.74 (99.62%)	📈 view plot 🚷 view threshold	11,688.00 (+0.12%)	11,745.12 (99.51%)	📈 view plot 🚨 view alert (🔔) 🚷 view threshold	87.00 (+16.62%)	85.93 (101.24%)	📈 view plot 🚷 view threshold	305.00 (+0.53%)	310.69 (98.17%)
client_sv2_setup_connection	📈 view plot 🚷 view threshold	4,715.00 (+0.62%)	4,780.19 (98.64%)	📈 view plot 🚷 view threshold	1,502.00 (-0.02%)	1,517.67 (98.97%)	📈 view plot 🚷 view threshold	2,275.00 (-0.15%)	2,299.30 (98.94%)	📈 view plot 🚷 view threshold	12.00 (+25.18%)	16.60 (72.27%)	📈 view plot 🚷 view threshold	68.00 (+0.87%)	69.96 (97.20%)
client_sv2_setup_connection_serialize	📈 view plot 🚷 view threshold	16,214.00 (+0.32%)	16,419.76 (98.75%)	📈 view plot 🚷 view threshold	5,963.00 (-0.01%)	5,978.67 (99.74%)	📈 view plot 🚷 view threshold	8,654.00 (-0.11%)	8,691.54 (99.57%)	📈 view plot 🚷 view threshold	49.00 (+22.96%)	53.22 (92.08%)	📈 view plot 🚷 view threshold	209.00 (+0.21%)	215.27 (97.09%)
client_sv2_setup_connection_serialize_deserialize	📈 view plot 🚷 view threshold	35,718.00 (+0.44%)	35,810.15 (99.74%)	📈 view plot 🚷 view threshold	14,888.00 (+0.23%)	14,911.83 (99.84%)	📈 view plot 🚷 view threshold	21,868.00 (+0.21%)	21,923.06 (99.75%)	📈 view plot 🚷 view threshold	110.00 (+19.31%)	111.48 (98.67%)	📈 view plot 🚷 view threshold	380.00 (+0.18%)	384.97 (98.71%)

🐰 View full continuous benchmarking report in Bencher

github-actions · 2024-11-17T16:23:47Z

Bencher Report

Branch	2024-11-08-template-distribution-msgs-docs
Testbed	sv2

Click to view all benchmark results

Benchmark	Latency	Benchmark Result nanoseconds (ns) (Result Δ%)	Upper Boundary nanoseconds (ns) (Limit %)
client_sv2_handle_message_common	📈 view plot 🚷 view threshold	44.57 (+0.06%)	46.85 (95.13%)
client_sv2_handle_message_mining	📈 view plot 🚷 view threshold	74.75 (-1.19%)	89.25 (83.76%)
client_sv2_mining_message_submit_standard	📈 view plot 🚷 view threshold	14.67 (+0.01%)	14.79 (99.20%)
client_sv2_mining_message_submit_standard_serialize	📈 view plot 🚷 view threshold	262.22 (-0.48%)	300.01 (87.40%)
client_sv2_mining_message_submit_standard_serialize_deserialize	📈 view plot 🚷 view threshold	656.41 (+6.38%)	708.43 (92.66%)
client_sv2_open_channel	📈 view plot 🚷 view threshold	166.60 (+6.11%)	197.50 (84.36%)
client_sv2_open_channel_serialize	📈 view plot 🚷 view threshold	278.19 (-2.24%)	314.35 (88.50%)
client_sv2_open_channel_serialize_deserialize	📈 view plot 🚷 view threshold	377.59 (-1.02%)	410.95 (91.88%)
client_sv2_setup_connection	📈 view plot 🚷 view threshold	164.54 (+2.57%)	170.18 (96.69%)
client_sv2_setup_connection_serialize	📈 view plot 🚷 view threshold	466.70 (-0.73%)	556.20 (83.91%)
client_sv2_setup_connection_serialize_deserialize	📈 view plot 🚷 view threshold	980.39 (-0.62%)	1,100.68 (89.07%)

🐰 View full continuous benchmarking report in Bencher

github-actions · 2024-11-17T16:23:57Z

Bencher Report

Branch	2024-11-08-template-distribution-msgs-docs
Testbed	sv1

Click to view all benchmark results

Benchmark	Latency	Benchmark Result nanoseconds (ns) (Result Δ%)	Upper Boundary nanoseconds (ns) (Limit %)
client-submit-serialize	📈 view plot 🚷 view threshold	6,568.60 (-1.60%)	7,249.50 (90.61%)
client-submit-serialize-deserialize	📈 view plot 🚷 view threshold	7,346.00 (-3.06%)	8,217.59 (89.39%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle	📈 view plot 🚷 view threshold	8,104.80 (-0.61%)	8,689.10 (93.28%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle	📈 view plot 🚷 view threshold	864.82 (+0.03%)	924.97 (93.50%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize	📈 view plot 🚷 view threshold	679.27 (+0.78%)	711.61 (95.46%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize	📈 view plot 🚷 view threshold	246.47 (-1.08%)	274.00 (89.95%)
client-sv1-get-authorize/client-sv1-get-authorize	📈 view plot 🚷 view threshold	155.87 (-0.76%)	162.78 (95.76%)
client-sv1-get-submit	📈 view plot 🚷 view threshold	6,548.80 (+0.80%)	7,236.92 (90.49%)
client-sv1-get-subscribe/client-sv1-get-subscribe	📈 view plot 🚷 view threshold	290.56 (+3.74%)	308.91 (94.06%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle	📈 view plot 🚷 view threshold	732.18 (+0.47%)	788.52 (92.86%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize	📈 view plot 🚷 view threshold	589.84 (-0.53%)	639.96 (92.17%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize	📈 view plot 🚷 view threshold	206.78 (+0.56%)	215.78 (95.83%)

🐰 View full continuous benchmarking report in Bencher

github-actions · 2024-11-17T16:23:57Z

Bencher Report

Branch	2024-11-08-template-distribution-msgs-docs
Testbed	sv1

Click to view all benchmark results

Benchmark	Estimated Cycles	Benchmark Result estimated cycles (Result Δ%)	Upper Boundary estimated cycles (Limit %)	Instructions	Benchmark Result instructions (Result Δ%)	Upper Boundary instructions (Limit %)	L1 Accesses	Benchmark Result accesses (Result Δ%)	Upper Boundary accesses (Limit %)	L2 Accesses	Benchmark Result accesses (Result Δ%)	Upper Boundary accesses (Limit %)	RAM Accesses	Benchmark Result accesses (Result Δ%)	Upper Boundary accesses (Limit %)
get_authorize	📈 view plot 🚷 view threshold	8,416.00 (-0.57%)	8,731.04 (96.39%)	📈 view plot 🚷 view threshold	3,691.00 (-1.47%)	3,864.92 (95.50%)	📈 view plot 🚷 view threshold	5,151.00 (-1.91%)	5,442.25 (94.65%)	📈 view plot 🚷 view threshold	9.00 (+22.29%)	13.93 (64.59%)	📈 view plot 🚷 view threshold	92.00 (+1.38%)	95.55 (96.29%)
get_submit	📈 view plot 🚷 view threshold	95,334.00 (-0.09%)	95,879.40 (99.43%)	📈 view plot 🚷 view threshold	59,291.00 (-0.27%)	59,706.27 (99.30%)	📈 view plot 🚷 view threshold	85,114.00 (-0.32%)	85,802.12 (99.20%)	📈 view plot 🚷 view threshold	49.00 (+9.82%)	62.45 (78.47%)	📈 view plot 🚷 view threshold	285.00 (+1.69%)	289.93 (98.30%)
get_subscribe	📈 view plot 🚷 view threshold	7,933.00 (-1.08%)	8,277.03 (95.84%)	📈 view plot 🚷 view threshold	2,786.00 (-1.62%)	2,943.43 (94.65%)	📈 view plot 🚷 view threshold	3,873.00 (-2.11%)	4,132.62 (93.72%)	📈 view plot 🚷 view threshold	14.00 (+17.12%)	20.58 (68.04%)	📈 view plot 🚷 view threshold	114.00 (-0.33%)	118.61 (96.12%)
serialize_authorize	📈 view plot 🚷 view threshold	12,205.00 (-0.63%)	12,565.95 (97.13%)	📈 view plot 🚷 view threshold	5,268.00 (-0.94%)	5,431.65 (96.99%)	📈 view plot 🚷 view threshold	7,320.00 (-1.27%)	7,599.37 (96.32%)	📈 view plot 🚷 view threshold	11.00 (+19.32%)	16.73 (65.74%)	📈 view plot 🚷 view threshold	138.00 (+0.15%)	142.65 (96.74%)
serialize_deserialize_authorize	📈 view plot 🚷 view threshold	24,638.00 (-0.25%)	25,213.59 (97.72%)	📈 view plot 🚷 view threshold	9,814.00 (-0.74%)	10,041.71 (97.73%)	📈 view plot 🚷 view threshold	13,828.00 (-0.93%)	14,203.38 (97.36%)	📈 view plot 🚷 view threshold	34.00 (-1.92%)	43.70 (77.81%)	📈 view plot 🚷 view threshold	304.00 (+0.68%)	314.85 (96.55%)
serialize_deserialize_handle_authorize	📈 view plot 🚷 view threshold	30,229.00 (-0.32%)	30,746.76 (98.32%)	📈 view plot 🚷 view threshold	12,017.00 (-0.50%)	12,208.99 (98.43%)	📈 view plot 🚷 view threshold	16,994.00 (-0.63%)	17,306.95 (98.19%)	📈 view plot 🚷 view threshold	57.00 (+2.53%)	67.46 (84.50%)	📈 view plot 🚷 view threshold	370.00 (+0.02%)	381.40 (97.01%)
serialize_deserialize_handle_submit	📈 view plot 🚷 view threshold	126,464.00 (-0.01%)	126,894.49 (99.66%)	📈 view plot 🚷 view threshold	73,117.00 (-0.22%)	73,526.56 (99.44%)	📈 view plot 🚷 view threshold	104,759.00 (-0.28%)	105,469.59 (99.33%)	📈 view plot 🚷 view threshold	113.00 (+5.92%)	130.95 (86.29%)	📈 view plot 🚷 view threshold	604.00 (+1.21%)	606.60 (99.57%)
serialize_deserialize_handle_subscribe	📈 view plot 🚷 view threshold	27,869.00 (+0.05%)	28,580.05 (97.51%)	📈 view plot 🚷 view threshold	9,605.00 (-0.43%)	9,757.00 (98.44%)	📈 view plot 🚷 view threshold	13,559.00 (-0.62%)	13,817.97 (98.13%)	📈 view plot 🚷 view threshold	69.00 (+8.45%)	76.38 (90.34%)	📈 view plot 🚷 view threshold	399.00 (+0.51%)	416.24 (95.86%)
serialize_deserialize_submit	📈 view plot 🚷 view threshold	115,181.00 (-0.06%)	115,785.45 (99.48%)	📈 view plot 🚷 view threshold	67,894.00 (-0.30%)	68,413.27 (99.24%)	📈 view plot 🚷 view threshold	97,356.00 (-0.38%)	98,259.95 (99.08%)	📈 view plot 🚷 view threshold	72.00 (+14.41%)	79.71 (90.33%)	📈 view plot 🚷 view threshold	499.00 (+1.48%)	500.20 (99.76%)
serialize_deserialize_subscribe	📈 view plot 🚷 view threshold	23,242.00 (-0.15%)	23,960.21 (97.00%)	📈 view plot 🚷 view threshold	8,157.00 (-0.55%)	8,313.38 (98.12%)	📈 view plot 🚷 view threshold	11,467.00 (-0.74%)	11,726.00 (97.79%)	📈 view plot 🚷 view threshold	38.00 (+1.69%)	44.96 (84.51%)	📈 view plot 🚷 view threshold	331.00 (+0.41%)	346.99 (95.39%)
serialize_submit	📈 view plot 🚷 view threshold	99,791.00 (-0.05%)	100,298.83 (99.49%)	📈 view plot 🚷 view threshold	61,353.00 (-0.24%)	61,736.98 (99.38%)	📈 view plot 🚷 view threshold	87,971.00 (-0.30%)	88,634.01 (99.25%)	📈 view plot 🚷 view threshold	54.00 (+15.43%)	64.72 (83.44%)	📈 view plot 🚷 view threshold	330.00 (+1.54%)	334.91 (98.53%)
serialize_subscribe	📈 view plot 🚷 view threshold	11,412.00 (+0.04%)	11,678.37 (97.72%)	📈 view plot 🚷 view threshold	4,139.00 (-0.98%)	4,285.98 (96.57%)	📈 view plot 🚷 view threshold	5,732.00 (-1.41%)	5,985.54 (95.76%)	📈 view plot 🚷 view threshold	16.00 (+23.52%)	21.34 (74.98%)	📈 view plot 🚷 view threshold	160.00 (+1.28%)	163.63 (97.78%)

🐰 View full continuous benchmarking report in Bencher

jbesraa · 2024-11-19T15:09:49Z

@GitGab19 this is ready for initial review

GitGab19

Overall LGTM, I left some minor comments.

protocols/v2/subprotocols/template-distribution/README.md

protocols/v2/subprotocols/template-distribution/src/coinbase_output_data_size.rs

protocols/v2/subprotocols/template-distribution/src/lib.rs

protocols/v2/subprotocols/template-distribution/src/new_template.rs

protocols/v2/subprotocols/template-distribution/src/request_transaction_data.rs

protocols/v2/subprotocols/template-distribution/src/set_new_prev_hash.rs

Shourya742

I have a few general questions about structs with C memory layout, along with some minor nit. The description in the messaging is really detailed.

protocols/v2/subprotocols/template-distribution/src/coinbase_output_data_size.rs

Shourya742 · 2024-11-21T15:14:49Z

protocols/v2/subprotocols/template-distribution/src/new_template.rs

    pub coinbase_tx_locktime: u32,
    /// Merkle path hashes ordered from deepest.
    #[cfg_attr(feature = "with_serde", serde(borrow))]
    pub merkle_path: Seq0255<'decoder, U256<'decoder>>,
 }

+/// Message used by an upstream to provide a new template for downstream to mine on.
 #[repr(C)]
 #[cfg(not(feature = "with_serde"))]
 pub struct CNewTemplate {


Not related to doc this struct should be like this, to have more efficient memory layout, and not waste space in padding.

#[repr(C)] #[cfg(not(feature = "with_serde"))] pub struct CNewTemplate { future_template: bool, coinbase_tx_locktime: u32, version: u32, coinbase_tx_input_sequence: u32, coinbase_tx_outputs_count: u32, template_id: u64, coinbase_tx_value_remaining: u64, coinbase_prefix: CVec, coinbase_tx_outputs: CVec, merkle_path: CVec2, }

Same, this is for refactoring not documentation

protocols/v2/subprotocols/template-distribution/src/request_transaction_data.rs

protocols/v2/subprotocols/template-distribution/src/set_new_prev_hash.rs

protocols/v2/subprotocols/template-distribution/src/submit_solution.rs

protocols/v2/subprotocols/template-distribution/README.md

protocols/v2/subprotocols/template-distribution/src/coinbase_output_data_size.rs

protocols/v2/subprotocols/template-distribution/src/lib.rs

protocols/v2/subprotocols/template-distribution/README.md

protocols/v2/subprotocols/template-distribution/src/request_transaction_data.rs

protocols/v2/subprotocols/template-distribution/src/set_new_prev_hash.rs

protocols/v2/subprotocols/template-distribution/src/submit_solution.rs

GitGab19

LGTM. Left few minor nits

protocols/v2/subprotocols/template-distribution/README.md

protocols/v2/subprotocols/template-distribution/src/lib.rs

protocols/v2/subprotocols/template-distribution/src/new_template.rs

protocols/v2/subprotocols/template-distribution/src/request_transaction_data.rs

protocols/v2/subprotocols/template-distribution/src/set_new_prev_hash.rs

GitGab19

Can you just fix the fmt, and rebase @jbesraa?
Maybe you can wait some minutes so that I can merge #1265 as soon as tests pass.

jbesraa · 2024-12-09T12:25:07Z

@GitGab19 done

GitGab19 mentioned this pull request Nov 18, 2024

Rust Docs + refactor: protocols crates #845

Open

78 tasks

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch 3 times, most recently from a877fed to 31e33f6 Compare November 19, 2024 14:38

jbesraa marked this pull request as ready for review November 19, 2024 14:39

GitGab19 self-requested a review November 20, 2024 09:33

GitGab19 reviewed Nov 20, 2024

View reviewed changes

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch 2 times, most recently from 97b62d7 to 1c25a28 Compare November 21, 2024 12:55

Shourya742 suggested changes Nov 21, 2024

View reviewed changes

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch from 1c25a28 to 765772d Compare December 2, 2024 09:19

Shourya742 mentioned this pull request Dec 2, 2024

Refactor: subprotocols crates #1202

Open

GitGab19 reviewed Dec 3, 2024

View reviewed changes

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch 2 times, most recently from b618c7d to 584cf99 Compare December 4, 2024 11:45

GitGab19 reviewed Dec 7, 2024

View reviewed changes

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch 2 times, most recently from 95ed9a6 to 1826593 Compare December 7, 2024 08:59

GitGab19 approved these changes Dec 9, 2024

View reviewed changes

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch from 1826593 to 9a44b3d Compare December 9, 2024 12:24

jbesraa and others added 4 commits December 9, 2024 14:24

Add README file

bdaa60c

Use shorter paths

df5a9d4

Improve Template Distribution subprotocol docs

99f6408

modify sv2.h to make it consistent with comments changes

7f388ce

jbesraa force-pushed the 2024-11-08-template-distribution-msgs-docs branch from 9a44b3d to 7f388ce Compare December 9, 2024 12:24

plebhash merged commit 5bcc26e into stratum-mining:main Dec 9, 2024
38 checks passed

plebhash mentioned this pull request Dec 17, 2024

Need Rust docs on protocols::v2::subprotocols #1201

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs for Template Distribution Messages #1257

Docs for Template Distribution Messages #1257

jbesraa commented Nov 17, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

jbesraa commented Nov 19, 2024

GitGab19 left a comment

Shourya742 left a comment

Shourya742 Nov 21, 2024

jbesraa Dec 2, 2024

GitGab19 left a comment

GitGab19 left a comment

jbesraa commented Dec 9, 2024

Docs for Template Distribution Messages #1257

Docs for Template Distribution Messages #1257

Conversation

jbesraa commented Nov 17, 2024

codecov bot commented Nov 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 17, 2024 • edited Loading

Bencher Report

🚨 4 Alerts

github-actions bot commented Nov 17, 2024 • edited Loading

Bencher Report

github-actions bot commented Nov 17, 2024 • edited Loading

Bencher Report

github-actions bot commented Nov 17, 2024 • edited Loading

Bencher Report

jbesraa commented Nov 19, 2024

GitGab19 left a comment

Choose a reason for hiding this comment

Shourya742 left a comment

Choose a reason for hiding this comment

Shourya742 Nov 21, 2024

Choose a reason for hiding this comment

jbesraa Dec 2, 2024

Choose a reason for hiding this comment

GitGab19 left a comment

Choose a reason for hiding this comment

GitGab19 left a comment

Choose a reason for hiding this comment

jbesraa commented Dec 9, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024 •

edited

Loading