Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scripts/release-libs.sh #1329

Merged
merged 1 commit into from
Jan 7, 2025
Merged

add scripts/release-libs.sh #1329

merged 1 commit into from
Jan 7, 2025

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Jan 6, 2025 •
edited
Loading

close #1327

this PR adds a new scripts/release-libs.sh, which is used to publish each crate to crates.io

the script returns 0 on success of cargo publish, and 1 on failure
the only exception is when cargo publish fails because the crate is already published
in that case, the script also returns 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

🐰 Bencher Report

Branchadd-release-libs-sh
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,571.50
(-0.10%)		6,945.75
(94.61%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,253.50
(-2.21%)		7,894.56
(91.88%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,945.30
(-2.07%)		9,457.63
(84.01%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		861.55
(-0.98%)		948.01
(90.88%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		670.66
(-0.66%)		718.83
(93.30%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		245.98
(-1.32%)		266.49
(92.30%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		157.23
(-0.36%)		167.27
(94.00%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,308.50
(-0.82%)		6,815.99
(92.55%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		279.38
(-1.63%)		328.70
(84.99%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		742.26
(+1.75%)		782.23
(94.89%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		589.85
(-0.38%)		626.83
(94.10%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		207.39
(+0.11%)		227.44
(91.19%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

🐰 Bencher Report

Branchadd-release-libs-sh
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.17
(-2.27%)		60.47
(73.04%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		75.10
(-3.49%)		108.04
(69.51%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.65
(-0.08%)		14.72
(99.52%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		261.83
(-1.54%)		292.15
(89.62%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		631.85
(+2.81%)		655.90
(96.33%)
client_sv2_open_channel📈 view plot
🚷 view threshold		165.68
(-0.18%)		179.41
(92.35%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		278.64
(-1.98%)		307.38
(90.65%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		386.74
(+1.28%)		400.44
(96.58%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		165.62
(+3.17%)		173.47
(95.47%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		461.58
(-1.66%)		546.81
(84.41%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		985.18
(-1.49%)		1,153.52
(85.41%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

🐰 Bencher Report

Branchadd-release-libs-sh
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.13
(+1.03%)		2.23
(95.48%)		📈 view plot
🚷 view threshold		473.00
(-0.09%)		490.93
(96.35%)		📈 view plot
🚷 view threshold		733.00
(-0.39%)		759.87
(96.46%)		📈 view plot
🚷 view threshold		7.00
(+39.78%)		11.95
(58.59%)		📈 view plot
🚷 view threshold		39.00
(+1.09%)		41.65
(93.64%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.31
(+1.06%)		8.39
(99.02%)		📈 view plot
🚷 view threshold		2,137.00
(-0.00%)		2,138.71
(99.92%)		📈 view plot
🚷 view threshold		3,155.00
(-0.12%)		3,168.11
(99.59%)		📈 view plot
🚷 view threshold		37.00
(+4.00%)		41.82
(88.47%)		📈 view plot
🚷 view threshold		142.00
(+1.72%)		144.31
(98.40%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.36
(+0.98%)		6.45
(98.67%)		📈 view plot
🚷 view threshold		1,750.00
(-0.03%)		1,767.83
(98.99%)		📈 view plot
🚷 view threshold		2,546.00
(-0.23%)		2,576.19
(98.83%)		📈 view plot
🚷 view threshold		21.00
(+22.29%)		24.65
(85.20%)		📈 view plot
🚷 view threshold		106.00
(+1.32%)		108.70
(97.52%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.82
(+0.63%)		14.93
(99.21%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,711.83
(99.62%)		📈 view plot
🚷 view threshold		6,746.00
(-0.15%)		6,786.85
(99.40%)		📈 view plot
🚷 view threshold		53.00
(+17.23%)		62.06
(85.40%)		📈 view plot
🚷 view threshold		223.00
(+0.83%)		226.21
(98.58%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.84
(+0.92%)		28.03
(99.32%)		📈 view plot
🚷 view threshold		10,645.00
(+0.38%)		10,693.09
(99.55%)		📈 view plot
🚷 view threshold		15,504.00
(+0.44%)		15,584.18
(99.49%)		📈 view plot
🚷 view threshold		88.00
(+5.46%)		98.73
(89.14%)		📈 view plot
🚷 view threshold		340.00
(+1.38%)		342.82
(99.18%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.49
(+2.09%)		4.57
(98.27%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,478.93
(98.79%)		📈 view plot
🚷 view threshold		2,154.00
(-0.31%)		2,185.33
(98.57%)		📈 view plot
🚷 view threshold		12.00
(+47.55%)		13.98
(85.87%)		📈 view plot
🚷 view threshold		65.00
(+3.61%)		67.36
(96.50%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14.08
(+0.43%)		14.20
(99.17%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,081.93
(99.65%)		📈 view plot
🚷 view threshold		7,318.00
(-0.11%)		7,353.07
(99.52%)		📈 view plot
🚷 view threshold		43.00
(+18.52%)		48.01
(89.57%)		📈 view plot
🚷 view threshold		187.00
(+0.53%)		190.89
(97.96%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.95
(+1.13%)		23.03
(99.66%)		📈 view plot
🚷 view threshold		8,040.00
(+0.11%)		8,056.96
(99.79%)		📈 view plot
🚷 view threshold		11,687.00
(+0.03%)		11,714.02
(99.77%)		📈 view plot
🚷 view threshold		83.00
(+9.90%)		89.46
(92.77%)		📈 view plot
🚷 view threshold		310.00
(+2.04%)		311.77
(99.43%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.71
(+0.56%)		4.79
(98.44%)		📈 view plot
🚷 view threshold		1,502.00
(-0.03%)		1,519.93
(98.82%)		📈 view plot
🚷 view threshold		2,275.00
(-0.15%)		2,301.75
(98.84%)		📈 view plot
🚷 view threshold		12.00
(+27.36%)		15.48
(77.54%)		📈 view plot
🚷 view threshold		68.00
(+0.71%)		70.08
(97.03%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.23
(+0.48%)		16.32
(99.46%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,980.93
(99.70%)		📈 view plot
🚷 view threshold		8,650.00
(-0.16%)		8,693.04
(99.50%)		📈 view plot
🚷 view threshold		53.00
(+31.80%)		55.30
(95.84%)		📈 view plot
🚷 view threshold		209.00
(+0.39%)		212.03
(98.57%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.81
(+0.62%)		35.93
(99.67%)		📈 view plot
🚷 view threshold		14,888.00
(+0.15%)		14,916.60
(99.81%)		📈 view plot
🚷 view threshold		21,867.00
(+0.12%)		21,915.58
(99.78%)		📈 view plot
🚷 view threshold		108.00
(+15.28%)		118.05
(91.49%)		📈 view plot
🚷 view threshold		383.00
(+0.92%)		385.51
(99.35%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

🐰 Bencher Report

Branchadd-release-libs-sh
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
1e3 x instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
1e3 x accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.48
(+0.34%)		8.67
(97.82%)		📈 view plot
🚷 view threshold		3.66
(-1.75%)		3.86
(94.88%)		📈 view plot
🚷 view threshold		5.11
(-2.16%)		5.44
(93.80%)		📈 view plot
🚷 view threshold		10.00
(+21.10%)		15.81
(63.26%)		📈 view plot
🚷 view threshold		95.00
(+4.16%)		96.38
(98.57%)
get_submit📈 view plot
🚷 view threshold		95.38
(+0.02%)		95.63
(99.74%)		📈 view plot
🚷 view threshold		59.26
(-0.25%)		59.70
(99.26%)		📈 view plot
🚷 view threshold		85.07
(-0.29%)		85.81
(99.14%)		📈 view plot
🚷 view threshold		46.00
(+3.61%)		59.87
(76.83%)		📈 view plot
🚷 view threshold		288.00
(+2.69%)		290.82
(99.03%)
get_subscribe📈 view plot
🚷 view threshold		7.96
(-0.52%)		8.23
(96.66%)		📈 view plot
🚷 view threshold		2.76
(-2.06%)		2.94
(93.72%)		📈 view plot
🚷 view threshold		3.83
(-2.47%)		4.14
(92.50%)		📈 view plot
🚷 view threshold		13.00
(+5.45%)		20.45
(63.56%)		📈 view plot
🚷 view threshold		116.00
(+1.30%)		117.83
(98.45%)
serialize_authorize📈 view plot
🚷 view threshold		12.30
(+0.34%)		12.50
(98.38%)		📈 view plot
🚷 view threshold		5.24
(-1.16%)		5.43
(96.59%)		📈 view plot
🚷 view threshold		7.28
(-1.47%)		7.60
(95.74%)		📈 view plot
🚷 view threshold		11.00
(+9.66%)		18.58
(59.20%)		📈 view plot
🚷 view threshold		142.00
(+3.03%)		142.69
(99.51%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.74
(+0.12%)		25.18
(98.25%)		📈 view plot
🚷 view threshold		9.79
(-0.76%)		10.01
(97.77%)		📈 view plot
🚷 view threshold		13.78
(-0.96%)		14.17
(97.25%)		📈 view plot
🚷 view threshold		36.00
(+0.48%)		45.75
(78.70%)		📈 view plot
🚷 view threshold		308.00
(+1.52%)		313.14
(98.36%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.33
(+0.02%)		30.72
(98.73%)		📈 view plot
🚷 view threshold		11.99
(-0.54%)		12.19
(98.39%)		📈 view plot
🚷 view threshold		16.95
(-0.69%)		17.29
(98.00%)		📈 view plot
🚷 view threshold		59.00
(+5.84%)		67.28
(87.69%)		📈 view plot
🚷 view threshold		374.00
(+0.83%)		379.06
(98.67%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.52
(+0.05%)		126.78
(99.79%)		📈 view plot
🚷 view threshold		73.12
(-0.19%)		73.53
(99.44%)		📈 view plot
🚷 view threshold		104.76
(-0.24%)		105.50
(99.30%)		📈 view plot
🚷 view threshold		109.00
(+2.56%)		125.53
(86.83%)		📈 view plot
🚷 view threshold		606.00
(+1.43%)		608.97
(99.51%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.93
(+0.05%)		28.39
(98.36%)		📈 view plot
🚷 view threshold		9.58
(-0.59%)		9.76
(98.13%)		📈 view plot
🚷 view threshold		13.52
(-0.76%)		13.84
(97.69%)		📈 view plot
🚷 view threshold		68.00
(+5.57%)		77.69
(87.52%)		📈 view plot
🚷 view threshold		402.00
(+0.71%)		409.81
(98.09%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.31
(+0.06%)		115.71
(99.66%)		📈 view plot
🚷 view threshold		67.89
(-0.25%)		68.41
(99.24%)		📈 view plot
🚷 view threshold		97.35
(-0.32%)		98.28
(99.06%)		📈 view plot
🚷 view threshold		71.00
(+9.56%)		86.37
(82.21%)		📈 view plot
🚷 view threshold		503.00
(+2.03%)		503.06
(99.99%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.35
(+0.09%)		23.82
(98.00%)		📈 view plot
🚷 view threshold		8.13
(-0.73%)		8.32
(97.76%)		📈 view plot
🚷 view threshold		11.42
(-0.92%)		11.74
(97.25%)		📈 view plot
🚷 view threshold		40.00
(+3.31%)		50.57
(79.11%)		📈 view plot
🚷 view threshold		335.00
(+1.04%)		342.36
(97.85%)
serialize_submit📈 view plot
🚷 view threshold		99.88
(+0.09%)		100.10
(99.78%)		📈 view plot
🚷 view threshold		61.33
(-0.22%)		61.73
(99.34%)		📈 view plot
🚷 view threshold		87.93
(-0.27%)		88.64
(99.20%)		📈 view plot
🚷 view threshold		51.00
(+6.89%)		66.26
(76.97%)		📈 view plot
🚷 view threshold		334.00
(+2.72%)		336.31
(99.31%)
serialize_subscribe📈 view plot
🚷 view threshold		11.47
(+0.66%)		11.60
(98.95%)		📈 view plot
🚷 view threshold		4.11
(-1.30%)		4.28
(95.98%)		📈 view plot
🚷 view threshold		5.69
(-1.69%)		6.00
(94.87%)		📈 view plot
🚷 view threshold		16.00
(+17.30%)		23.52
(68.04%)		📈 view plot
🚷 view threshold		163.00
(+2.91%)		163.95
(99.42%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (815012a) to head (5211c2f).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (815012a) and HEAD (5211c2f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (815012a) HEAD (5211c2f)
error_handling-coverage 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   24.78%   19.29%   -5.50%     
==========================================
  Files         111      164      +53     
  Lines        7584    10852    +3268     
==========================================
+ Hits         1880     2094     +214     
- Misses       5704     8758    +3054
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage ?
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (?)
jd_server-coverage 7.79% <ø> (?)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (?)
mining_proxy_sv2-coverage 0.70% <ø> (?)
noise_sv2-coverage 4.35% <ø> (+0.01%) ⬆️
pool_sv2-coverage 1.38% <ø> (?)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (?)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (?)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jbesraa
jbesraa suggested changes Jan 7, 2025
View reviewed changes
.github/workflows/release-libs.yaml Outdated Show resolved Hide resolved
.github/workflows/release-libs.yaml Show resolved Hide resolved
scripts/release-libs.sh Outdated Show resolved Hide resolved
@plebhash plebhash force-pushed the add-release-libs-sh branch 2 times, most recently from e7349ef to edde215 Compare January 7, 2025 12:34
@plebhash plebhash force-pushed the add-release-libs-sh branch from edde215 to 5211c2f Compare January 7, 2025 13:04
@plebhash plebhash merged commit d8ef9e8 into stratum-mining:main Jan 7, 2025
37 checks passed
@plebhash plebhash deleted the add-release-libs-sh branch January 7, 2025 13:39
@plebhash plebhash mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbesraa jbesraa jbesraa requested changes

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release-libs.yaml has a footgun continue-on-error: true
3 participants
@plebhash @jbesraa @GitGab19